Bug 1435330

Summary: Review Request: perl-Dist-Zilla-Plugin-LicenseFromModule - Extract license and copyright from its main module file
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Dist-Zilla-Plugin-LicenseFromModule-0.05-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-29 07:14:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2017-03-23 14:44:21 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-LicenseFromModule/perl-Dist-Zilla-Plugin-LicenseFromModule.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-LicenseFromModule/perl-Dist-Zilla-Plugin-LicenseFromModule-0.05-1.fc27.src.rpm
Description:
This is is a Dist::Zilla plugin to extract license, author and copyright year
from your main module's POD document.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2017-03-27 10:15:02 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Dist-Zilla-Plugin-LicenseFromModule-0.05-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Dist::Zilla) >= 4.30003
      1 perl(Dist::Zilla::Role::LicenseProvider)
      1 perl(Module::Load) >= 0.32
      1 perl(Moose)
      1 perl(Software::LicenseUtils)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Plugin-LicenseFromModule-0.05-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Plugin::LicenseFromModule) = 0.05
      1 perl-Dist-Zilla-Plugin-LicenseFromModule = 0.05-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-LicenseFromModule*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires are almost ok
FIX: Please remove build-require 'make', it is not used.

Please correct 'FIX' issue.

Otherwise package looks good.
Approved
Comment 2 Gwyn Ciesla 2017-03-28 18:57:03 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-LicenseFromModule
Comment 3 Petr Pisar 2017-03-29 07:14:52 UTC 
Thank you for the review and the repository. I removed the dependency.