Bug 1435576

Summary: Missing ess-julia.jl leads to backtrace
Product: [Fedora] Fedora Reporter: Suvayu <fatkasuvayu>
Component: emacs-common-essAssignee: José Matos <jamatos>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: alex, jamatos
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: emacs-common-ess-16.10-3.fc24 emacs-common-ess-16.10-3.fc25 emacs-common-ess-16.10-3.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-25 17:22:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Spec file patch none

Description Suvayu 2017-03-24 09:32:54 UTC
Created attachment 1266023 [details]
Spec file patch

Description of problem:
ESS produces a backtrace when used with Julia due to the missing ess-julia.jl file.

Version-Release number of selected component (if applicable):
All

How reproducible:
Always

Steps to Reproduce:
1. Install Julia: dnf install julia
2. Start Emacs with ESS loaded.
3. Start ESS for Julia: M-x julia RET

Actual results:
Debugger entered--Lisp error: (file-missing "Opening input file" "No such file or directory" "/usr/share/emacs/site-lisp/ess/etc/ess-julia.jl")
  insert-file-contents("/usr/share/emacs/site-lisp/ess/etc/ess-julia.jl")
  ess--inject-code-from-file("/usr/share/emacs/site-lisp/ess/etc/ess-julia.jl")
  julia(nil)
  funcall-interactively(julia nil)
  call-interactively(julia record nil)
  command-execute(julia record)
  execute-extended-command(nil "julia" nil)
  funcall-interactively(execute-extended-command nil "julia" nil)
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)


Expected results:
No backtrace

Additional info:
The backtrace happens because the julia function in the file lisp/ess-julia.el loads the missing julia file; see: 
https://github.com/emacs-ess/ESS/blob/abacd7538e1bbfdd6ef2b5f11d4f5f4cc74782ee/lisp/ess-julia.el#L421

I have attached a patch that should fix the issue.

Comment 1 José Matos 2017-03-28 08:49:23 UTC
Thank you for the feedback.

You are right that the file is missing. I suspect that there was a problem when the tar was generated as reported in
https://stat.ethz.ch/pipermail/ess-help/2016-November/011088.html

The julia-mode.el was missing as well and I had to add it manually.

I am using your patch and rebuilding the package for all the available Fedora releases.

Comment 2 Suvayu 2017-03-28 10:02:37 UTC
Thanks for the prompt response and reference to the upstream issue.  I tested out the new builds on koji, works as expected.

Comment 3 Fedora Update System 2017-03-28 15:51:12 UTC
emacs-common-ess-16.10-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c5dc0e0d28

Comment 4 Fedora Update System 2017-03-28 15:51:19 UTC
emacs-common-ess-16.10-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c5dc0e0d28

Comment 5 Fedora Update System 2017-03-28 15:53:49 UTC
emacs-common-ess-16.10-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b6ccc4a0c6

Comment 6 Fedora Update System 2017-03-28 15:53:54 UTC
emacs-common-ess-16.10-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b6ccc4a0c6

Comment 7 Fedora Update System 2017-03-28 15:55:05 UTC
emacs-common-ess-16.10-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-00d5e1968c

Comment 8 Fedora Update System 2017-03-28 15:55:10 UTC
emacs-common-ess-16.10-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-00d5e1968c

Comment 9 Fedora Update System 2017-03-29 03:53:13 UTC
emacs-common-ess-16.10-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-00d5e1968c

Comment 10 Fedora Update System 2017-03-29 04:22:59 UTC
emacs-common-ess-16.10-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b6ccc4a0c6

Comment 11 Fedora Update System 2017-03-29 17:49:18 UTC
emacs-common-ess-16.10-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c5dc0e0d28

Comment 12 Fedora Update System 2017-04-25 17:22:35 UTC
emacs-common-ess-16.10-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2017-04-25 17:54:35 UTC
emacs-common-ess-16.10-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-04-25 21:33:20 UTC
emacs-common-ess-16.10-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.