Bug 1435779
Summary: | Inode ref leak on anonymous reads and writes | ||||||
---|---|---|---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Simon Turcotte-Langevin <simon.turcotte-langevin> | ||||
Component: | libgfapi | Assignee: | Niels de Vos <ndevos> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Sudhir D <sdharane> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 3.10 | CC: | bugs, ndevos, rtalur, simon.turcotte-langevin, skoduri | ||||
Target Milestone: | --- | Keywords: | Triaged | ||||
Target Release: | --- | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | glusterfs-3.10.2 | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | |||||||
: | 1438738 (view as bug list) | Environment: | |||||
Last Closed: | 2017-05-31 20:45:58 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 1438738 | ||||||
Bug Blocks: | 1442603 | ||||||
Attachments: |
|
Description
Simon Turcotte-Langevin
2017-03-24 18:12:17 UTC
We do not support GlusterFS 3.10 in Red Hat Gluster Storage, so I assume this is a bug against the community version of Gluster and am relocating this bug. I can reproduce the problem on one of my test systems with CentOS 7 and glusterfs-3.8.10. Created attachment 1266452 [details]
Example program logging leaked inodes
Compile this program with (assuming that the file is saved as bug-1435779.c):
$ make CFLAGS="$(pkg-config --cflags --libs glusterfs-api)" bug-1435779
Run it with:
$ ./bug-1435779 <hostname> <volname>
# <hostname> is a gluster server
# <volname> is a name of a volume
The bug-1435779.log file will contain the warning after running:
[2017-03-25 23:59:50.253520] W [inode.c:1809:inode_table_destroy] (-->/lib64/libgfapi.so.0(glfs_fini+0x40d) [0x7f958a1f794d] -->/lib64/libglusterfs.so.0(inode_table_destroy_all+0x51) [0x7f9589f37111] -->/lib64/libglusterfs.so.0(inode_table_destroy+0xd7) [0x7f9589f37017] ) 0-gfapi: Active inode(0x7f95693d1128) with refcount(1) found during cleanup
REVIEW: https://review.gluster.org/16989 (gfapi: Fix inode ref leak in anonymous fd I/O APIs) posted (#1) for review on master by soumya k (skoduri) REVIEW: https://review.gluster.org/17074 (gfapi: Fix inode ref leak in anonymous fd I/O APIs) posted (#1) for review on release-3.10 by Niels de Vos (ndevos) COMMIT: https://review.gluster.org/17074 committed in release-3.10 by Raghavendra Talur (rtalur) ------ commit 12da472023f20ec0950d6a16125edd79e46812a0 Author: Soumya Koduri <skoduri> Date: Tue Apr 4 15:50:29 2017 +0530 gfapi: Fix inode ref leak in anonymous fd I/O APIs In the APIs to do I/Os using anonymous fd, there is a ref taken for inode which hasn't been unreferenced post the operation. This shall result in the leak. Cherry picked from commit 761e2dc0432d3723e0f8cbb1cf192ad386addb08: > Change-Id: I75ea952a6b2df58c385f4f53398e5562f255248d > BUG: 1438738 > Signed-off-by: Soumya Koduri <skoduri> > Reviewed-on: https://review.gluster.org/16989 > Reviewed-by: Prashanth Pai <ppai> > Smoke: Gluster Build System <jenkins.org> > Reviewed-by: jiffin tony Thottan <jthottan> > Reviewed-by: Niels de Vos <ndevos> > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> Change-Id: I75ea952a6b2df58c385f4f53398e5562f255248d BUG: 1435779 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: https://review.gluster.org/17074 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> Reviewed-by: jiffin tony Thottan <jthottan> Reviewed-by: soumya k <skoduri> CentOS-regression: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report. |