Bug 1436030

Summary: tar: --add-file broken
Product: [Fedora] Fedora Reporter: Stas Sergeev <stsp2>
Component: tarAssignee: Tomas Repik <trepik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 25CC: kdudka, ovasik, praiskup, trepik
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tar-1.29-5.fc26 tar-1.29-4.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-20 15:54:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch to fix the issue trepik: review?

Description Stas Sergeev 2017-03-26 22:31:12 UTC 
Description of problem:
tar supplied in fedora-25 has --add-file option broken.

Version-Release number of selected component (if applicable):
tar-1.29-3.fc25.x86_64

How reproducible:
easily

Steps to Reproduce:
1. echo >a.txt
2. echo >b.txt
3. tar cf a.tar a.txt
4. tar rf a.tar --add-file=b.txt

Actual results:
tar: unhandled positional option 0

Expected results:
Should work, as it always did in the previous
fedora releases

Additional info:
Is likely fixed by this:
http://git.savannah.gnu.org/cgit/tar.git/commit/?id=3a283cfe9f8f1f127e8dc5597a5ea1d249985a54
Comment 1 Pavel Raiskup 2017-03-27 05:29:31 UTC 
(In reply to Stas Sergeev from comment #0)
> Is likely fixed by this:
> http://git.savannah.gnu.org/cgit/tar.git/commit/
> ?id=3a283cfe9f8f1f127e8dc5597a5ea1d249985a54

Correct, thanks for the report.
Comment 2 Tomas Repik 2017-06-05 08:03:06 UTC 
Created attachment 1284971 [details]
patch to fix the issue
Comment 3 Tomas Repik 2017-06-05 08:04:07 UTC 
I applied the patch to tar in f25, here is a scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19715991

You could either approve my request for commit rights to tar and let me update the package, or you could review and apply the attached patch yourself.

Thanks
Comment 4 Fedora Update System 2017-07-18 15:12:42 UTC 
tar-1.29-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-04d751ec2f
Comment 5 Fedora Update System 2017-07-19 04:26:16 UTC 
tar-1.29-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-04d751ec2f
Comment 6 Pavel Raiskup 2017-07-19 05:46:33 UTC 
Is it intentional to fix only F25?  Not fixing F26 and Rawhide means that
there's potential for regressions after fedora upgrades.
Comment 7 Fedora Update System 2017-07-19 09:52:34 UTC 
tar-1.29-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2f289580a3
Comment 8 Fedora Update System 2017-07-20 00:26:30 UTC 
tar-1.29-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2f289580a3
Comment 9 Fedora Update System 2017-07-20 15:54:30 UTC 
tar-1.29-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2017-07-23 22:55:24 UTC 
tar-1.29-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.