Bug 1436387

Summary:	[RHOSP10] Controller replacement fails with AllNodesValidationConfig
Product:	Red Hat OpenStack	Reporter:	Alex Schultz <aschultz>
Component:	openstack-tripleo-heat-templates	Assignee:	Alex Schultz <aschultz>
Status:	CLOSED ERRATA	QA Contact:	Gurenko Alex <agurenko>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	10.0 (Newton)	CC:	jjoyce, jschluet, mburns, rhel-osp-director-maint
Target Milestone:	z3	Keywords:	Triaged, ZStream
Target Release:	10.0 (Newton)
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-5.2.0-18.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-28 14:48:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1435075

Description Alex Schultz 2017-03-27 20:03:02 UTC

+++ This bug was initially created as a clone of Bug #1435075 +++

1. Bug Overview:
a) Summary:

  Controller replacement fails when replaying controller with ID of 0 results in a stack validation error.

b) Bug Description: 

  I tried to replace a controller node according to the following procedure.

  https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/10/html/director_installation_and_usage/sect-scaling_the_overcloud#sect-Replacing_Controller_Nodes

  I can successfully replace controller node whose node index is other than "0".
  However if I tried to replace the node with index "0", unexpected error has occurred at step 8.4.2(Node Replacement).

  NOTE: I know it is expected to encounter a particular error at step 8.4.2.
        But I got another error and I cannot continue the procedure.

  Version-Release number of selected component:
    openstack-tripleo-heat-templates-5.2.0-3.el7ost.noarch
    openstack-heat-engine-7.0.1-2.el7ost.noarch
    openstack-heat-common-7.0.1-2.el7ost.noarch
    openstack-heat-templates-0-0.10.1e6015dgit.el7ost.noarch
    python-tripleoclient-5.4.1-1.el7ost.noarch
    openstack-tripleo-0.0.8-0.2.4de13b3git.el7ost.noarch
    openstack-tripleo-common-5.4.1-1.el7ost.noarch

2. Bug Details:
a) Steps to Reproduce: 

   1. create overcloud with 3 controller

   stack$ openstack overcloud deploy --templates [OTHER OPTIONS] --control-scale 3 --compute-scale 1

   2. replacing(removing) the node index with "0" 

   stack$ cat ~/templates/remove-controller.yaml
   parameters:
     ControllerRemovalPolicies:
        [{'resource_list': ['0']}]

   stack$ openstack overcloud deploy --templates [OTHER OPTIONS] -e ~/templates/remove-controller.yaml --controller-scale 3 --compute-scale 1

b) Actual results: 

  The Overcloud stack update halts with an UPDATE_FAILED error at AllNodesValidationConfig. 

2017-03-10 05:44:20Z [AllNodesValidationConfig]: UPDATE_IN_PROGRESS  state changed
2017-03-10 05:44:20Z [AllNodesValidationConfig]: UPDATE_FAILED  StackValidationFailed: resources.AllNodesValidationConfig: Property error: AllNodesValidationConfig.Properties.PingTestIps: The Referenced Attribute (Controller resource.0.external_ip_address) is incorrect.
2017-03-10 05:44:20Z [overcloud-ControllerIpListMap-pzv7ph4qyi6n]: UPDATE_IN_PROGRESS  Stack UPDATE started
2017-03-10 05:44:20Z [ControllerIpListMap]: UPDATE_FAILED  UPDATE aborted
2017-03-10 05:44:20Z [overcloud]: UPDATE_FAILED  StackValidationFailed: resources.AllNodesValidationConfig: Property error: AllNodesValidationConfig.Properties.PingTestIps: The Referenced Attribute (Controller resource.0.external_ip_address) is incorrect.
2017-03-10 05:44:20Z [overcloud-ControllerIpListMap-pzv7ph4qyi6n]: UPDATE_COMPLETE  Stack UPDATE completed successfully

  Stack overcloud UPDATE_FAILED

Comment 4 Gurenko Alex 2017-06-01 11:36:45 UTC

With build 2017-05-23.4:

2017-06-01 11:22:31Z [AllNodesDeploySteps]: UPDATE_COMPLETE  state changed
2017-06-01 11:22:43Z [overcloud]: UPDATE_COMPLETE  Stack UPDATE completed successfully

 Stack overcloud UPDATE_COMPLETE

Replacement worked without any problems.

[stack@undercloud-0 ~]$ rpm -q openstack-tripleo-heat-templates
openstack-tripleo-heat-templates-5.2.0-18.el7ost.noarch

Comment 6 errata-xmlrpc 2017-06-28 14:48:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1585