Bug 1436412

Summary:	Unrecognized filesystems (i.e. btrfs, zfs) log many errors about "getinode size"
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	glusterd	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	http://lists.gluster.org/pipermail/gluster-users/2017-March/030189.html
Whiteboard:
Fixed In Version:	glusterfs-3.8.11	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1433425	Environment:
Last Closed:	2017-04-11 09:07:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1433425
Bug Blocks:	1431410

Description Niels de Vos 2017-03-27 21:07:15 UTC

+++ This bug was initially created as a clone of Bug #1433425 +++

Description of problem:
hi, I have replicated glusterfs on 3 nodes with zfs, the logs are flooded
with inodes error

[2017-03-06 16:24:15.019386] E [MSGID: 106419]
[glusterd-utils.c:5458:glusterd_add_inode_size_to_dict] 0-management: could
not find (null) to getinode size for zclei21/01 (zfs): (null) package
missing?

Version-Release number of selected component (if applicable):
3.9

How reproducible:
100%

Steps to Reproduce:
1. configure a volume with bricks on btrfs or zfs
2. run 'gluster volume status <VOLNAME> detail'

Actual results:
Upon each execution of 'gluster volume status <VOLNAME> detail' log entries are added.

Expected results:
No logs, or maybe once.

Additional info:
Reported on http://lists.gluster.org/pipermail/gluster-users/2017-March/030189.html

--- Additional comment from Worker Ant on 2017-03-17 16:53:58 CET ---

REVIEW: https://review.gluster.org/16867 (glusterd: support filesystems with dynamic inode sizes) posted (#2) for review on master by Niels de Vos (ndevos)

--- Additional comment from Worker Ant on 2017-03-27 18:57:34 CEST ---

COMMIT: https://review.gluster.org/16867 committed in master by Atin Mukherjee (amukherj) 
------
commit 12921693b572f642156d3167d1c92d3449dfc8ec
Author: Niels de Vos <ndevos>
Date:   Tue Mar 7 18:01:25 2017 +0100

    glusterd: support filesystems with dynamic inode sizes
    
    btrfs and zfs are two filesystems that do not have fixed sizes for
    inodes. Instead of logging an error, skip checking and mark the size as
    "N/A" like other properties that can not be reported.
    
    The error message that was reported by users on the mailinglist shows up
    like:
    
      [glusterd-utils.c:5458:glusterd_add_inode_size_to_dict] 0-management: could not find (null) to getinode size for /dev/vdb (btrfs): (null) package missing?
    
    Change-Id: Ib10b7a3669f2f4221075715d9fd44ce1ffc35324
    Reported-by: Arman Khalatyan <arm2arm>
    URL: http://lists.gluster.org/pipermail/gluster-users/2017-March/030189.html
    BUG: 1433425
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: https://review.gluster.org/16867
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Prashanth Pai <ppai>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-03-27 21:10:22 UTC

REVIEW: https://review.gluster.org/16960 (glusterd: support filesystems with dynamic inode sizes) posted (#1) for review on release-3.8 by Niels de Vos (ndevos)

Comment 2 Worker Ant 2017-04-07 11:57:25 UTC

COMMIT: https://review.gluster.org/16960 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit abe5b927878bb72e177942a79586300d98ac44f8
Author: Niels de Vos <ndevos>
Date:   Tue Mar 7 18:01:25 2017 +0100

    glusterd: support filesystems with dynamic inode sizes
    
    btrfs and zfs are two filesystems that do not have fixed sizes for
    inodes. Instead of logging an error, skip checking and mark the size as
    "N/A" like other properties that can not be reported.
    
    The error message that was reported by users on the mailinglist shows up
    like:
    
      [glusterd-utils.c:5458:glusterd_add_inode_size_to_dict] 0-management: could not find (null) to getinode size for /dev/vdb (btrfs): (null) package missing?
    
    Cherry picked from commit 12921693b572f642156d3167d1c92d3449dfc8ec:
    > Change-Id: Ib10b7a3669f2f4221075715d9fd44ce1ffc35324
    > Reported-by: Arman Khalatyan <arm2arm>
    > URL: http://lists.gluster.org/pipermail/gluster-users/2017-March/030189.html
    > BUG: 1433425
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: https://review.gluster.org/16867
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > Reviewed-by: Prashanth Pai <ppai>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    
    Change-Id: Ib10b7a3669f2f4221075715d9fd44ce1ffc35324
    Reported-by: Arman Khalatyan <arm2arm>
    BUG: 1436412
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: https://review.gluster.org/16960
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Zhou Zhengping <johnzzpcrystal>

Comment 3 Niels de Vos 2017-04-11 09:07:22 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.11, please open a new bug report.

glusterfs-3.8.11 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/packaging/2017-April/000289.html
[2] https://www.gluster.org/pipermail/gluster-users/