Bug 1436577

Summary:	Solve DC/Cluster upgrade of VMs with now-unsupported custom compatibility level
Product:	[oVirt] ovirt-engine	Reporter:	Michal Skrivanek <michal.skrivanek>
Component:	BLL.Virt	Assignee:	Shahar Havivi <shavivi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Artyom <alukiano>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.1.0	CC:	bugs, eedri, mavital, sbendavi, tjelinek
Target Milestone:	ovirt-4.1.2	Keywords:	Triaged
Target Release:	4.1.2.2	Flags:	rule-engine: ovirt-4.1? tjelinek: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-23 08:11:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michal Skrivanek 2017-03-28 08:46:04 UTC

When you override cluster compatibility version the checks on cluster upgrade are not correct.
E.g. In 4.1 when you set CCV to 3.6, then after upgrade 4.2 drops 3.6 support but the VM still has CCV 3.6 which doesn't really work anymore.

Similarly on DC upgrade when you cannot support lower (existing) CCV
3.6 DC, 4.0 Cluster, set CCV to 3.6. Now upgrade DC to 4.0 where 3.6 is not valid anymore

Comment 1 Michal Skrivanek 2017-03-28 11:05:17 UTC

- pre-upgrade check needs to verify no VM has CCV unsupported by the new version
- fail to run a VM with CCV not actually supported (lower than the DC level or not supported overall)

Comment 2 rhev-integ 2017-04-26 10:49:13 UTC

INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[TAG 'ovirt-engine-4.1.2' DOESN'T CONTAIN PATCH 'https://gerrit.ovirt.org/75859']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.1.2

For more info please contact: infra

Comment 4 Artyom 2017-05-16 05:57:33 UTC

Verified on rhevm-4.1.2-0.1.el7.noarch

1) Update via database compatibility version of one of VM's to 3.5
2) run engine-setup
[ INFO  ] Hosted Engine HA is in Global Maintenance mode.
[ ERROR ] Failed to execute stage 'Setup validation': Cannot upgrade the Engine due to low custom_compatibility_version for virtual machines: ['test_vm']. Please edit this virtual machines, in edit VM dialog go to System->Advanced Parameters -> Custom Compatibility Version and either reset to empty (cluster default) or set a value supported by the new installation: 3.6,4.0,4.1.
[ INFO  ] Stage: Clean up

3) Start the VM
Error while executing action: 

test_vm:
Cannot run VM. The Custom Compatibility Version of VM test_vm (3.5) is not supported in Data Center compatibility version 4.1.