Bug 1436598

Summary:	[RFE] Configure and load postgresql collectd plugin on engine machine if the database is local
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Shirly Radco <sradco>
Component:	RFEs	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED NOTABUG	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.0.1	CC:	bugs, didi, pstehlik, ylavi
Target Milestone:	ovirt-4.1.3	Keywords:	FutureFeature
Target Release:	---	Flags:	sradco: ovirt-4.1? sradco: planning_ack? sradco: devel_ack? sradco: testing_ack?
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-28 10:12:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1436001
Bug Blocks:	1402901

Description Shirly Radco 2017-03-28 09:34:06 UTC

Description of problem:
If the postgresql collectd plugin is not configured correctly it will fail Collectd from starting.

We need to enable it only if its is actually configured and the database is local.

Comment 1 Yedidyah Bar David 2017-04-24 10:15:19 UTC

Yaniv - please reply here to bug 1429861 comment 13. Thanks. For that bug I don't separate local/remote dbs.

Comment 2 Yaniv Lavi 2017-05-21 07:44:56 UTC

(In reply to Yedidyah Bar David from comment #13)
> (In reply to Yaniv Dary from comment #12)
> > - We can not assume we are the owners of the postgres and have permission to
> > the stats. 
> 
> Indeed, and this is true also for a local db. We are going to use engine db
> creds, which should work the same whether local or remote.
> 
> > - Most likely it is monitored on the remote site 
> 
> Indeed. But IMO there is some added value in monitoring and keeping stats
> etc. in our own store even then. E.g. one day we might base decisions on
> these stats, and would like to be able to make these decisions also for
> remote dbs.
> 
> > - We need to be able to work out of the box and not have collectd fail on no
> > prmissions to stats table for example.
> 
> See above.
> 
> Do we need permissions that the engine db user does not have? 

I depends on what the admin user defined in that instance and I don't think we should collect from remote unless we are sure we will not fail on permissions.

Comment 3 Yedidyah Bar David 2017-05-21 11:25:31 UTC

(In reply to Yaniv Dary from comment #2)
> (In reply to Yedidyah Bar David from comment #13)
> > Do we need permissions that the engine db user does not have? 
> 
> I depends on what the admin user defined in that instance

I do not understand. Which admin user?

> and I don't think
> we should collect from remote unless we are sure we will not fail on
> permissions.

If we need extra permissions, we should ask for them. Do we?

Please note that this applies also to local db.