Bug 1436777

Summary: F26AH is not using overlay storage driver by default
Product: [Fedora] Fedora Reporter: Dusty Mabe <dustymabe>
Component: dockerAssignee: smahajan <smahajan>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: adimania, admiller, amurdaca, dwalsh, ichavero, jcajka, lsm5, marianne, miminar, nalin, riek, smahajan, vbatts, vgoyal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: docker-1.13.1-6.git5be1549.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-09 05:58:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dusty Mabe 2017-03-28 15:59:23 UTC
Description of problem:

The system comes up with device mapper as the default because the scriptlet that runs does not properly detect that it is an atomic host system:

[root@cloudhost ~]# rpm -q docker
docker-1.13.1-3.git5be1549.fc26.x86_64
[root@cloudhost ~]# cat /etc/os-release | grep VARIANT_ID
VARIANT_ID=atomic.host
[root@cloudhost ~]# rpm -q docker --scripts | grep atomichost 
        atomichost)
            cp /usr/share/docker-storage-setup/docker-storage-setup-atomichost /etc/sysconfig/docker-storage-setup || :


you can see the case statement compares against 'atomichost' rather than 'atomic.host'.

Comment 1 Vivek Goyal 2017-03-28 16:02:22 UTC
Lokesh,

Can you please have a look at this one.

Comment 2 Lokesh Mandvekar 2017-03-28 17:42:06 UTC
fix incoming ...

Comment 3 Fedora Update System 2017-03-31 14:56:04 UTC
docker-1.13.1-6.git5be1549.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-80cdb3361d

Comment 4 Fedora Update System 2017-04-02 00:51:24 UTC
docker-1.13.1-6.git5be1549.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-80cdb3361d

Comment 5 Dusty Mabe 2017-04-06 12:05:17 UTC
Got around to testing this today. The docker-storage-setup file looks good:


```
[root@cloudhost ~]# cat /etc/sysconfig/docker-storage-setup 
# Edit this file to override any configuration options specified in
# /usr/share/container-storage-setup/container-storage-setup.
#
# For more details refer to "man container-storage-setup"
STORAGE_DRIVER=overlay2
CONTAINER_ROOT_LV_NAME=docker-root-lv
CONTAINER_ROOT_LV_MOUNT_PATH=/var/lib/docker
GROWPART=true
```

but the docker-storage-setup service barfs:


```
[root@cloudhost ~]# journalctl -u docker-storage-setup.service -o cat
Starting Docker Storage Setup...
CHANGED: partition=2 start=616448 old: size=20355072 end=20971520 new: size=41326592,end=41943040
  Physical volume "/dev/sda2" changed
  1 physical volume(s) resized / 0 physical volume(s) not resized
/usr/bin/container-storage-setup: line 972: Fatal: command not found
/usr/bin/container-storage-setup: line 974: check_data_size_syntax: command not found
/usr/bin/container-storage-setup: line 975: Fatal: command not found
  Invalid argument for --size: docker-root-lv
  Error during parsing of command line.
/usr/bin/container-storage-setup: line 941: Fatal: command not found
Error accessing specified device /dev/atomicos/docker-root-lv: No such file or directory
Usage: mkfs.xfs
/* blocksize */         [-b log=n|size=num]
/* metadata */          [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1]
/* data subvol */       [-d agcount=n,agsize=n,file,name=xxx,size=num,
                            (sunit=value,swidth=value|su=num,sw=num|noalign),
                            sectlog=n|sectsize=num
/* force overwrite */   [-f]
/* inode size */        [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,
                            projid32bit=0|1,sparse=0|1]
/* no discard */        [-K]
/* log subvol */        [-l agnum=n,internal,size=num,logdev=xxx,version=n
                            sunit=value|su=num,sectlog=n|sectsize=num,
                            lazy-count=0|1]
/* label */             [-L label (maximum 12 characters)]
/* naming */            [-n log=n|size=num,version=2|ci,ftype=0|1]
/* no-op info only */   [-N]
/* prototype file */    [-p fname]
/* quiet */             [-q]
/* realtime subvol */   [-r extsize=num,size=num,rtdev=xxx]
/* sectorsize */        [-s log=n|size=num]
/* version */           [-V]
                        devicename
<devicename> is required unless -d name=xxx is given.
<num> is xxx (bytes), xxxs (sectors), xxxb (fs blocks), xxxk (xxx KiB),
      xxxm (xxx MiB), xxxg (xxx GiB), xxxt (xxx TiB) or xxxp (xxx PiB).
<value> is xxx (512 byte blocks).
/usr/bin/container-storage-setup: line 945: Fatal: command not found
mount: special device /dev/atomicos/docker-root-lv does not exist
/usr/bin/container-storage-setup: line 949: Fatal: command not found
Started Docker Storage Setup.
```

VERSIONS:
```
[root@cloudhost ~]# rpm -q docker container-storage-setup 
docker-1.13.1-6.git5be1549.fc26.x86_64
container-storage-setup-0.1.0-2.fc26.noarch
```

Comment 6 Vivek Goyal 2017-04-06 12:26:18 UTC
I think lokesh later found out another packaging issue where we seem to be fetching from wrong tree. 

He was planning to fix it. Lokesh, have you already made the changes?

Comment 7 Fedora Update System 2017-04-09 05:58:14 UTC
docker-1.13.1-6.git5be1549.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.