Bug 1436871

Summary: setBfree core dumps on start
Product: [Fedora] Fedora Reporter: L.L.Robinson <junk>
Component: setBfreeAssignee: Guido Aulisi <guido.aulisi>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: guido.aulisi
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-13 08:45:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Output of running gdb with the debuginfo version of setbfree
none
backtrace of scratch build setBfree-0.8.4-3.fc25 none

Description L.L.Robinson 2017-03-28 22:09:43 UTC
Description of problem:

setBfree coredumps on start 

Version-Release number of selected component (if applicable):
[baggypants@swordfish2 ~]$ rpm -qi setBfree
Name        : setBfree
Version     : 0.8.4
Release     : 1.fc25
Architecture: x86_64
Install Date: Tue 28 Mar 2017 22:57:46 BST
Group       : Unspecified
Size        : 6642186
License     : GPLv2+ and GPLv3+ and ISC
Signature   : RSA/SHA256, Sat 07 Jan 2017 23:51:19 GMT, Key ID 4089d8f2fdb19c98
Source RPM  : setBfree-0.8.4-1.fc25.src.rpm
Build Date  : Sat 07 Jan 2017 23:38:34 GMT
Build Host  : buildvm-32.phx2.fedoraproject.org
Relocations : (not relocatable)
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : http://setbfree.org
Summary     : A DSP Tonewheel Organ emulator


How reproducible:
always

Steps to Reproduce:
1. start jack (I use qjackctl)
2. run setBfreeUI or setBfree
3.

Actual results:
[baggypants@swordfish2 ~]$ setBfree
Illegal instruction (core dumped)


Expected results:
It to run

Additional info:

Comment 1 L.L.Robinson 2017-03-28 22:14:06 UTC
Created attachment 1267174 [details]
Output of running gdb with the debuginfo version of setbfree

seems to be an issue with robtk

Comment 2 Guido Aulisi 2017-03-28 22:36:17 UTC
Can you please add the output of lscpu or cat /proc/cpuinfo?
It seems the CPU tried to execute an illegal instruction. The x86_64 version is compiled with some advanced flags that could generate instruction your CPU cannot execute.
Thanks

Comment 3 L.L.Robinson 2017-03-28 22:42:42 UTC
[baggypants@swordfish2 ~]$ lscpu
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                2
On-line CPU(s) list:   0,1
Thread(s) per core:    1
Core(s) per socket:    2
Socket(s):             1
NUMA node(s):          1
Vendor ID:             AuthenticAMD
CPU family:            20
Model:                 1
Model name:            AMD E-350 Processor
Stepping:              0
CPU MHz:               1600.000
CPU max MHz:           1600.0000
CPU min MHz:           800.0000
BogoMIPS:              3193.16
Virtualization:        AMD-V
L1d cache:             32K
L1i cache:             32K
L2 cache:              512K
NUMA node0 CPU(s):     0,1
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc extd_apicid aperfmperf pni monitor ssse3 cx16 popcnt lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch ibs skinit wdt hw_pstate vmmcall arat npt lbrv svm_lock nrip_save pausefilter

Comment 4 L.L.Robinson 2017-03-28 22:43:45 UTC
I don't get the coredump on my own packaged verson https://copr.fedorainfracloud.org/coprs/baggypants/setBfree-stable/build/533643/

Comment 5 Guido Aulisi 2017-03-29 08:23:56 UTC
Can you please try this scratch build from koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18659213

I think you only installed setBfree, so the new build is:
https://kojipkgs.fedoraproject.org//work/tasks/9213/18659213/setBfree-0.8.4-3.fc25.x86_64.rpm

Thank you very much

Comment 6 L.L.Robinson 2017-03-30 09:53:05 UTC
Created attachment 1267473 [details]
backtrace of scratch build setBfree-0.8.4-3.fc25

Still coredumps, backtrace attached.

Comment 7 Guido Aulisi 2017-03-30 12:07:01 UTC
I made another build in copr:

https://copr-be.cloud.fedoraproject.org/results/tartina/Audio/fedora-25-x86_64/00534256-setBfree/setBfree-0.8.4-4.fc25.x86_64.rpm

This should work, I didn't notice your cpu is not compatible with sse4 instruction set (it's an AMD), I switched to ssse3 instruction set, which should be compatible with most Intel and AMD CPUs.

Sorry for the problem, I don't have any AMD CPUs to make tests.

Comment 8 L.L.Robinson 2017-03-30 13:02:39 UTC
The copr build works for me now.

I'd also like you to review this part of the packaging guidelines 

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

specifically "Overriding these flags for performance optimizations (for instance, -O3 instead of -O2) is generally discouraged"

Many thanks

Comment 9 Guido Aulisi 2017-03-30 13:31:56 UTC
Some flags were overridden because the package didn't build with upstream flags for other arches (like arm).
If you see the original spec file the -mavx was really a mistake, it was only a build test, but I forgot it in the spec later.
Being setBfree a real time audio software I tried to optimize it as much as possible, but I couldn't try it on an AMD cpu.

I will now update the package in the official repos.

Thanks for reporting and supporting

Comment 10 Fedora Update System 2017-03-30 14:09:00 UTC
setBfree-0.8.4-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab07298536

Comment 11 Fedora Update System 2017-03-30 14:36:59 UTC
setBfree-0.8.4-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a96e4d458

Comment 12 L.L.Robinson 2017-03-30 17:04:55 UTC
Sure, thanks for you're prompt resolution, please remember to document flag overrides rational in the spec file if you haven't already.

Comment 13 Fedora Update System 2017-03-30 18:54:07 UTC
setBfree-0.8.4-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab07298536

Comment 14 Fedora Update System 2017-03-31 03:22:31 UTC
setBfree-0.8.4-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a96e4d458

Comment 15 Fedora Update System 2017-04-03 16:09:34 UTC
setBfree-0.8.4-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2017-04-07 18:19:49 UTC
setBfree-0.8.4-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.