Bug 1436970

Summary:	Container Review Request - memcached - High Performance, Distributed Memory Object Cache
Product:	[Fedora] Fedora Container Images	Reporter:	Petr Hracek <phracek>
Component:	Container Review	Assignee:	Tomas Orsava <torsava>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	26	CC:	container-review, phracek, torsava
Target Milestone:	---	Flags:	torsava: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-13 11:46:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Hracek 2017-03-29 06:55:12 UTC

Container Build Info URL: https://github.com/container-images/memcached/blob/master/Dockerfile
Description: memcached is a high-performance, distributed memory object caching system, generic in nature, but intended for use in speeding up dynamic web applications by alleviating database load.
Fedora Account System Username: phracek

Comment 1 Tomas Orsava 2017-04-03 09:53:55 UTC

- Just a heads up: this bug is filed for Version: 26, but the Dockerfile is using fedora:24. I'm not even sure if PegDB/Container dist-git supports F24, I believe it's F25 and up.

- Missing required [labels]. In addition, the MAINTAINER instruction is now deprecated and should be changed to a LABEL MAINTAINER.

- Guidelines suggest to set te version to 0 for now for future compatibility, but this is not required. See [Versioning].

- While there is a help file included in the git repo, it should be also copied into the base directory of the image. See [Help file].

[labels] https://fedoraproject.org/wiki/Container:Guidelines#LABELS
[Versioning] https://fedoraproject.org/wiki/Container:Guidelines#VERSIONING
[Help file] https://fedoraproject.org/wiki/Container:Guidelines#Help_File

Comment 2 Petr Hracek 2017-04-03 11:15:46 UTC

Thanks for the review.

All things were updated. https://github.com/container-images/memcached/blob/master/Dockerfile

I would be glad for the review.
Experience with this Container Review Request will be shared in Modularity Team.

Comment 3 Tomas Orsava 2017-04-03 11:35:27 UTC

No problem!

The changes look good. It just needs 2 more labels:

- BZComponent: Existing Bugzilla component against which bugs in this image should be reported.
- Help: Required. Either a short description of how to run and use the container, or a link to a longer help file. See Help File below for more details.

A note: generally the labels are set right after the FROM instruction, before all the RUN commands. But it's not a rule.

Comment 4 Petr Hracek 2017-04-07 11:43:21 UTC

I have fixed all issues.

Hopefully last review;)

Comment 5 Tomas Orsava 2017-04-10 09:50:32 UTC

Looks good to me, approved!

Comment 6 Gwyn Ciesla 2017-04-11 12:22:44 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/memcached

Comment 7 Petr Hracek 2017-04-13 11:46:37 UTC

Memcached container is built https://koji.fedoraproject.org/koji/buildinfo?buildID=879883

CLOSING as NEXTRELEASE