Bug 1437152

Created attachment 1267324 [details]
logs

Description of problem:
The importing a vm from a VmWare external provider via REST API should perform the action as clone. When running the same action via UI, one can choose if to import as clone or not. When choosing as clone via UI the vm is imported and the mac address of it's nic is set to a new mac address from the engine's default mac pool range, overriding the original mac address with which this vm is set in VmWare.
When running the action via REST API, the import is done as clone (no choice in API, hopefully this could be added as well, will open RFE), but in this case, the original mac address persists and isn't overridden by new one for engine's default pool.

Attaching vdsm and engine logs, although not sure how helpful they can be. The time stamp for this import is around 17:53:50

Version-Release number of selected component (if applicable):
rhv-4.1.1.6-0.1.el7

How reproducible:
always

Steps to Reproduce:
1. Have a Vmware instance with some vm with nic having a mac address out of your ovirt engine's default mac pool.
2. Import this vm to the engine via API by invoking POST call to:
https://{engine_url}/ovirt-engine/api/externalvmimports/

body:
<external_vm_import>
   <vm>
     <name>some_name</name>
   </vm>
   <cluster id="{cluster_where_to_import" />
   <storage_domain id="{storage_where_to_import"/>
   <name>vmware_vm_name</name>
   <sparse>true</sparse>
   <username>{vmware_username}</username>
   <password>{vmware_password}</password>
   <provider>VMWARE</provider>
   <url>{url_to_vm_ware_cluster}</url>
 </external_vm_import>


Actual results:
Vm is imported successfully but the mac address isn't overridden by one from the engine's mac pool.

Expected results:
vm's mac address is overridden by one from the engine's mac pool.

Additional info: