Bug 1437337
Summary: | Hotplug cpu cores with invalid nr_threads causes qemu-kvm coredump | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Min Deng <mdeng> |
Component: | qemu-kvm-rhev | Assignee: | David Gibson <dgibson> |
Status: | CLOSED ERRATA | QA Contact: | Min Deng <mdeng> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 7.4 | CC: | dgibson, knoel, michen, mrezanin, qzhang, virt-maint, zhengtli |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | ppc64le | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | qemu-kvm-rhev-2.9.0-1.el7 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-08-02 04:35:59 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Min Deng
2017-03-30 06:45:24 UTC
It is a ppc64le specific issue since it is not reproduced on x86. Additional information about this bug. Tried it with nr_threads = 1,the hotplug successfully.Does it worked as expected ? Steps, 1.{"execute":"qmp_capabilities"} {"return": {}} 2.{"execute": "query-hotpluggable-cpus"} {"return": [{"props": {"core-id": 2}, "vcpus-count": 2, "type": "host-spapr-cpu-core"}, {"props": {"core-id": 0}, "vcpus-count": 2, "qom-path": "/machine/unattached/device[0]", "type": "host-spapr-cpu-core"}]} 3.{"execute": "device_add", "arguments": {"driver": "host-spapr-cpu-core", "core-id": 2, "nr-threads": 1, "id": "core1"}} {"return": {}} 4.{"execute": "query-hotpluggable-cpus"} {"return": [{"props": {"core-id": 2}, "vcpus-count": 2, "qom-path": "/machine/peripheral/core1", "type": "host-spapr-cpu-core"}, {"props": {"core-id": 0}, "vcpus-count": 2, "qom-path": "/machine/unattached/device[0]", "type": "host-spapr-cpu-core"}]} 5.{"execute": "query-cpus"} {"return": [{"arch": "ppc", "current": true, "CPU": 0, "nip": -4611686018426750380, "qom_path": "/machine/unattached/device[0]/thread[0]", "halted": false, "thread_id": 47258}, {"arch": "ppc", "current": false, "CPU": 1, "nip": -4611686018426750380, "qom_path": "/machine/unattached/device[0]/thread[1]", "halted": false, "thread_id": 47259}, {"arch": "ppc", "current": false, "CPU": 2, "nip": -4611686018426750380, "qom_path": "/machine/peripheral/core1/thread[0]", "halted": false, "thread_id": 47391}]} Problem also exists upstream. Upstream patch sent for review. Karen, I'm about to send a patch upstream, and it's pretty straightforward. Can you give this a devel_ack please? Fix is merged upstream for 2.9, so we should get it in the rebase. The bug can be reproduced on the previous build QE verified the bug on the following builds kernel-3.10.0-657.el7.ppc64le qemu-kvm-rhev-2.9.0-1.el7.ppc64le SLOF-20170303-1.git66d250e.el7.noarch Steps, 1.boot up guest with the similar cli - ..."-m 4G,slots=4,maxmem=8G -smp 2,maxcpus=4,cores=2,threads=2,sockets=1" 2.did the following steps - "nr-threads is 2" - (based on comment0 and comment3) 2.1{"execute": "device_add", "arguments": {"driver": "host-spapr-cpu-core", "core-id": 2, "nr-threads": 3, "id": "core1"}} {"error": {"class": "GenericError", "desc": "invalid nr-threads 3, must be 2"}} 2.2{"execute": "device_add", "arguments": {"driver": "host-spapr-cpu-core", "core-id": 2, "nr-threads": 1, "id": "core1"}} {"error": {"class": "GenericError", "desc": "invalid nr-threads 1, must be 2"}} Expected results, Invalid nr-threads should not be added. Actual results, Invalid nr-threads could not be added any more. Base on above test results,the bug has been fixed already,thanks for everyone's help.So move it to status verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:2392 |