Bug 143809

Summary: pair of local variables used before set
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: sambaAssignee: Simo Sorce <ssorce>
Status: CLOSED CURRENTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 3.0.24-1.fc6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-03-15 14:18:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2004-12-28 14:51:26 UTC
Description of problem:

I just tried to compile package samba-3.0.10-2 from 
Redhat Fedora development tree.

The compiler said

1.

smbd/lanman.c(2149): remark #592: variable "snum" is used before its
value is set

The source code is

                if (print_job_delete(&current_user, snum, jobid, &werr))

Suggest init snum before first use.

2.

smbd/lanman.c(2970): remark #592: variable "snum" is used before its
value is set

The source code is

  if (snum < 0 || !VALID_SNUM(snum)) return(False);

Suggest init snum before first use.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Guenther Deschner 2007-03-15 14:18:36 UTC
A lot of code cleanup has been done in Samba. This surely is fixed in 3.0.24,
please reopen if still an issue.

Comment 2 Guenther Deschner 2007-03-15 14:19:09 UTC
A lot of code cleanup has been done in Samba. This surely is fixed in 3.0.24,
please reopen if still an issue.