Bug 1438338

Summary:	glusterd is setting replicate volume property over disperse volume or vice versa
Product:	[Community] GlusterFS	Reporter:	Gaurav Yadav <gyadav>
Component:	glusterd	Assignee:	Gaurav Yadav <gyadav>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs, rtalur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1417588	Environment:
Last Closed:	2017-05-31 20:45:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1417588
Bug Blocks:	1442603

Description Gaurav Yadav 2017-04-03 06:38:19 UTC

+++ This bug was initially created as a clone of Bug #1417588 +++

Description of problem:glusterd is setting replicate volume property over disperse volume and viceversa lusterd is setting disperse volume property over replicate volume 



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
Case 1:
1.Create disperse volume
  gluster v create test-vol2 disperse 3 192.168.122.109:/d/backends/b{4,5,6} force

2. Try to set 
gluster volume set test-vol2 cluster.shd-max-threads 1222

3.
Check for output of above commands

Case 2:
1.Create replicate volume
  gluster v create test-vol replicate 3 192.168.122.109:/d/backends/b{4,5,6} force

2. Try to set 
gluster volume set test-vol2 disperse.shd-max-threads 1222

3.
Check for output of above command

Actual results:
For both the case glusterd is allowing client to set all values.(int, string)

Expected results:
For both the case glusterd should give error.



Additional info:

--- Additional comment from Worker Ant on 2017-01-31 05:46:21 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#1) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-02 04:41:22 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#2) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-13 05:19:13 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#3) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-13 12:59:32 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#4) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-22 05:19:41 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#5) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-03-06 02:21:55 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#6) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-03-06 05:22:52 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#7) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-03-06 07:45:27 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#8) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-03-06 08:04:21 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and disperse volume option) posted (#9) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-03-06 11:51:58 EST ---

COMMIT: https://review.gluster.org/16489 committed in master by Jeff Darcy (jdarcy) 
------
commit c618de80696c4572fad9e28f0454e63ebb2ff4ed
Author: Gaurav Yadav <gyadav>
Date:   Tue Jan 31 16:14:46 2017 +0530

    glusterd : Fix for replicate and disperse volume option
    
    While setting volume option(disperse-shd-max-threads) for
    replicate volume and volume option(cluster-shd-max-threads)
    for disperse volume, glusterd is not validating volume options
    and setting all the values irrespective of proper validation
    for disperse-shd-max-threads and cluster-shd-max-threads
    
    Change-Id: Ic88815ad49e901e74ffc042170f5caabf7c17a89
    BUG: 1417588
    Signed-off-by: Gaurav Yadav <gyadav>
    Reviewed-on: https://review.gluster.org/16489
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-04-03 06:43:31 UTC

REVIEW: https://review.gluster.org/16981 (glusterd : Fix for replicate and disperse volume option) posted (#1) for review on release-3.10 by Gaurav Yadav (gyadav)

Comment 2 Worker Ant 2017-04-13 15:35:48 UTC

COMMIT: https://review.gluster.org/16981 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 709c3c0dc86b26a30238b4fb09839ee2809e497d
Author: Gaurav Yadav <gyadav>
Date:   Tue Jan 31 16:14:46 2017 +0530

    glusterd : Fix for replicate and disperse volume option
    
    While setting volume option(disperse-shd-max-threads) for
    replicate volume and volume option(cluster-shd-max-threads)
    for disperse volume, glusterd is not validating volume options
    and setting all the values irrespective of proper validation
    for disperse-shd-max-threads and cluster-shd-max-threads
    
    
    > Reviewed-on: https://review.gluster.org/16489
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    
    (cherry picked from commit c618de80696c4572fad9e28f0454e63ebb2ff4ed)
    
    Change-Id: Ic88815ad49e901e74ffc042170f5caabf7c17a89
    BUG: 1438338
    Signed-off-by: Gaurav Yadav <gyadav>
    Reviewed-on: https://review.gluster.org/16981
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Samikshan Bairagya <samikshan>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Raghavendra Talur 2017-05-31 20:45:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report.