Bug 1438406

Summary:	Container Review Request - haproxy - HAProxy reverse proxy for high availability environments.
Product:	[Fedora] Fedora Container Images	Reporter:	Petr Hracek <phracek>
Component:	Container Review	Assignee:	Tomas Orsava <torsava>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	26	CC:	bperkins, container-review, gwync, phracek, torsava
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	torsava: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-20 12:01:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Hracek 2017-04-03 11:22:39 UTC

Container Build Info URL: https://github.com/container-images/haproxy/blob/master/Dockerfile
Description: HAProxy is a TCP/HTTP reverse proxy which is particularly suited for high availability environments.
Fedora Account System Username: phracek

Comment 1 Tomas Orsava 2017-04-11 08:31:50 UTC

Oops.

Comment 2 Tomas Orsava 2017-04-11 09:25:31 UTC

The Guidelines have been significantly overhauled since last week, so it would be good to also update the memcached image.

- It is required to use a fully qualified registry name in the FROM instruction: `FROM registry.fedoraproject.org/fedora:26`.

- The guidelines were updated and now the LABEL `BZComponent` has to be named `com.redhat.component`.

- The remaining LABELs should now be all lower-case, not Capitalised as previously.

- Suggestion: Move the LABEL definitions directly under the FROM instruction.

Comment 3 Petr Hracek 2017-04-12 07:21:29 UTC

Hi, I have fixed the issues.
Also for memcached.
https://github.com/container-images/haproxy/blob/master/Dockerfile

http://pkgs.fedoraproject.org/cgit/docker/memcached.git/tree/Dockerfile

Once you have time, please approve it, if it is fine.

Comment 4 Tomas Orsava 2017-04-12 11:40:19 UTC

Almost perfect, just the "Version" label is still capitalised in both Dockerfiles.

I'm approving the request, please fix it before pushing to dist-git.

Comment 5 Gwyn Ciesla 2017-04-13 11:44:33 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/haproxy

Comment 6 Petr Hracek 2017-04-18 11:24:36 UTC

Container cannot be built.

https://koji.fedoraproject.org/koji/taskinfo?taskID=19060064

Any idea?

Comment 7 Petr Hracek 2017-04-18 11:25:11 UTC

Sorry, switching back to NEW.

Comment 8 Gwyn Ciesla 2017-04-18 12:42:24 UTC

Sorry, I don't know anything about this process.  I imagine rel-eng or the atomic team could be of assistance.

Comment 9 Petr Hracek 2017-04-20 12:01:01 UTC

Container is built. https://koji.fedoraproject.org/koji/buildinfo?buildID=881166