Bug 1438811

Created attachment 1268650 [details]
valgrind.log

+++ This bug was initially created as a clone of Bug #1358467 +++

Description of problem:

I have a python script that calls rpm.readHeaderListFromFile() to check rpm headers. When calling this method iteratively over rpms in a yum repository, the python process' heap grows continuously. There appears to be a memory leak when creating the header object in librpm. A simple reproducer:

----
# cat rpm_hdr_test.py 
import rpm

for i in xrange(1000):
    hdr1 = rpm._rpm.hdr()
----

Running a memory leak test w/ valgrind:

----
# valgrind --leak-check=full --time-stamp=yes --log-file=rpm_hdr.log python rpm_hdr_test.py
----

shows the following:

----
==00:00:00:06.733 19733== 296,000 (40,000 direct, 256,000 indirect) bytes in 1,000 blocks are definitely lost in loss record 1,935 of 1,935
==00:00:00:06.733 19733==    at 0x4C2B974: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==00:00:00:06.733 19733==    by 0xDA8E2EE: rcalloc (rpmmalloc.c:55)
==00:00:00:06.733 19733==    by 0xCE38951: headerCreate (header.c:168)
==00:00:00:06.733 19733==    by 0xCC14FD4: hdr_new (header-py.c:394)
==00:00:00:06.733 19733==    by 0x4ED4E52: type_call (typeobject.c:729)
==00:00:00:06.733 19733==    by 0x4E7F0C2: PyObject_Call (abstract.c:2529)
==00:00:00:06.733 19733==    by 0x4F1338B: do_call (ceval.c:4316)
==00:00:00:06.733 19733==    by 0x4F1338B: call_function (ceval.c:4121)
==00:00:00:06.733 19733==    by 0x4F1338B: PyEval_EvalFrameEx (ceval.c:2740)
==00:00:00:06.733 19733==    by 0x4F171EC: PyEval_EvalCodeEx (ceval.c:3330)
==00:00:00:06.733 19733==    by 0x4F172F1: PyEval_EvalCode (ceval.c:689)
==00:00:00:06.733 19733==    by 0x4F3072E: run_mod (pythonrun.c:1374)
==00:00:00:06.733 19733==    by 0x4F318ED: PyRun_FileExFlags (pythonrun.c:1360)
==00:00:00:06.733 19733==    by 0x4F32B78: PyRun_SimpleFileExFlags (pythonrun.c:952)
----

Full log file is attached.


Version-Release number of selected component (if applicable):

rpm-4.8.0-55.el6.x86_64
rpm-libs-4.8.0-55.el6.x86_64
rpm-python-4.8.0-55.el6.x86_64

How reproducible:

100%

Steps to Reproduce:
1.) Create and deallocate multiple hdr objects in python with rpm.readHeaderListFromFile().
2.) See increasing heap size throughout lifetime of process.


Actual results:

Memory leak when creating hdr objects.

Expected results:

No memory leak.

Additional info:

See attached valgrind log.