Bug 1438839

Summary: Unable to edit the retirement tab in ansible playbook catalog item
Product: Red Hat CloudForms Management Engine Reporter: Dmitry Misharov <dmisharo>
Component: UI - OPSAssignee: Drew Bomhof <dbomhof>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: high    
Version: 5.8.0CC: cbolz, cpelland, gmccullo, hkataria, jdeubel, jhardy, mpovolny, obarenbo, simaishi, tachoi, vestival
Target Milestone: GAKeywords: Reopened, TestOnly
Target Release: 5.9.0   
Hardware: All   
OS: All   
Whiteboard: service:catalog:ansible
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1445942 (view as bug list) Environment:
Last Closed: 2018-03-06 15:43:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1445942    

Description Dmitry Misharov 2017-04-04 13:59:55 UTC
Description of problem:
If ansible catalog item was created without retirement it's i

Version-Release number of selected component (if applicable):
5.8.0.8-alpha1-nightly.20170404031010_4b327fc 

How reproducible:
Always

Steps to Reproduce:
1. Enable Embedded Ansible role.
2. Wait until it will be enabled.
3. Add some repository with ansible playbook.
4. Navigate to Services/Catalogs/Catalog Items.
5. Create ansible catalog item, don't fill retirement tab.
6. Click Configuration/Edit this Item.
7. Edit retirement tab.
8. Press Save button.

Actual results:
Error is raised:
Could not update Service Template - undefined method `manager_ref' for nil:NilClass

Expected results:
Catalog item should be saved with edited retirement tab.

Comment 2 Harpreet Kataria 2017-04-05 17:55:48 UTC
*** Bug 1439304 has been marked as a duplicate of this bug. ***

Comment 3 Harpreet Kataria 2017-04-05 21:02:10 UTC
*** Bug 1439368 has been marked as a duplicate of this bug. ***

Comment 4 Greg McCullough 2017-04-05 21:08:22 UTC

*** This bug has been marked as a duplicate of bug 1439305 ***

Comment 5 Greg McCullough 2017-04-05 21:10:18 UTC
*** Bug 1439305 has been marked as a duplicate of this bug. ***

Comment 11 CFME Bot 2017-04-25 21:31:25 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/4bcb4bd82287c22ef306db672025386da6a1c882

commit 4bcb4bd82287c22ef306db672025386da6a1c882
Author:     Drew Bomhof <dbomhof>
AuthorDate: Thu Apr 13 16:37:05 2017 -0400
Commit:     Drew Bomhof <dbomhof>
CommitDate: Mon Apr 17 15:53:11 2017 -0400

    Update a catalog item with a new retirement template
    
    When updating an existing AnsiblePlaybook catalog item - add the ability to add a new retirement playbook if one didn't previously exist before
    
    Testing notes:
    
    Create new Ansible Playbook Catalog item without a retirement playbook
    Edit the above Catalog Item and add a retirement playbook.
    
    https://www.pivotaltracker.com/story/show/141868401
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438839

 app/models/service_template_ansible_playbook.rb    | 34 ++++++++++++++++++----
 .../service_template_ansible_playbook_spec.rb      | 11 +++++++
 2 files changed, 39 insertions(+), 6 deletions(-)

Comment 12 CFME Bot 2017-04-25 21:31:31 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b979f0784b5918a46aeb65a523b4692fd91ae419

commit b979f0784b5918a46aeb65a523b4692fd91ae419
Author:     Drew Bomhof <dbomhof>
AuthorDate: Thu Apr 20 15:56:08 2017 -0400
Commit:     Drew Bomhof <dbomhof>
CommitDate: Thu Apr 20 15:56:08 2017 -0400

    Allow updating a catalog item to change/add job_templates
    
    When updating an existing AnsiblePlaybook catalog item - add the ability to add a new retirement playbook if one didn't previously exist before
    
    Also, allow deleting of an existing job_template if the update does not pass in a playbok id
    
    https://www.pivotaltracker.com/story/show/141868401
    
    https://www.pivotaltracker.com/story/show/141265431
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438839

 app/models/service_template_ansible_playbook.rb | 61 +++++++++++++++++--------
 1 file changed, 43 insertions(+), 18 deletions(-)

Comment 14 Dmitry Misharov 2017-10-12 07:41:27 UTC
Verified in 5.9.0.2.20171010190026_0413a06. No error raised during saving ansible catalog item with filled retirement tab.