Bug 1438858

Summary: explicitly specify executor to be bash for tests
Product: [Community] GlusterFS Reporter: Raghavendra Talur <rtalur>
Component: testsAssignee: Raghavendra Talur <rtalur>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, nbalacha
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.11.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1444773 (view as bug list) Environment:
Last Closed: 2017-05-30 18:49:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1444773    

Description Raghavendra Talur 2017-04-04 14:56:35 UTC
Description of problem:
We use prove command to run tests. Sometimes tests fail rather strangely with error as shown below:



Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
./tests/bugs/core/bug-1111557.t .. 
Dubious, test returned 25 (wstat 6400, 0x1900)
No subtests run

https://build.gluster.org/job/centos6-regression/3818/consoleFull
https://build.gluster.org/job/centos6-regression/3819/consoleFull
https://build.gluster.org/job/centos6-regression/3801/consoleFull



Quote from man page

```
 "--exec"
       Normally you can just pass a list of Perl tests and the harness will know how to execute them.  However, if your tests are
       not written in Perl or if you want all tests invoked exactly the same way, use the "-e", or "--exec" switch:

        prove --exec '/usr/bin/ruby -w' t/
```

Hence, better to comply with recommended practice although it might not be the reason for this failure.

Comment 1 Worker Ant 2017-04-04 14:59:33 UTC
REVIEW: https://review.gluster.org/16996 (explicitly specify executor to be bash for tests) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 2 Worker Ant 2017-04-04 15:18:50 UTC
REVIEW: https://review.gluster.org/16996 (explicitly specify executor to be bash for tests) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 3 Worker Ant 2017-04-05 13:09:44 UTC
COMMIT: https://review.gluster.org/16996 committed in master by Jeff Darcy (jeff.us) 
------
commit d6b88e9b8b02813620c3c1a2ea49d58d29062b3e
Author: Raghavendra Talur <rtalur>
Date:   Tue Apr 4 20:28:07 2017 +0530

    explicitly specify executor to be bash for tests
    
    We use prove command to run tests. Sometimes tests fail rather strangely
    with error as shown below:
    
    Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
    ./tests/bugs/core/bug-1111557.t ..
    Dubious, test returned 25 (wstat 6400, 0x1900)
    No subtests run
    
    https://build.gluster.org/job/centos6-regression/3818/consoleFull
    https://build.gluster.org/job/centos6-regression/3819/consoleFull
    https://build.gluster.org/job/centos6-regression/3801/consoleFull
    
    Quote from man page
    
    ``
     "--exec"
           Normally you can just pass a list of Perl tests and the harness
    will know how to execute them.  However, if your tests are not written in Perl
    or if you want all tests invoked exactly the same way, use the "-e",
    or "--exec" switch:
    
            prove --exec '/usr/bin/ruby -w' t/
    ```
    
    Hence, better to comply with recommended practice although it might not
    be the reason for this failure.
    
    Change-Id: If7a0baf20698f8497ef3e8fc422fa67063a4651f
    BUG: 1438858
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: https://review.gluster.org/16996
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: N Balachandran <nbalacha>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Nigel Babu <nigelb>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 4 Shyamsundar 2017-05-30 18:49:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/