Bug 1439130

Summary: unclear error report when migration start but failed with some reason
Product: Red Hat Enterprise Linux 7 Reporter: yafu <yafu>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED ERRATA QA Contact: yafu <yafu>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.4CC: dyuan, fjin, rbalakri, xuzhang, yafu, zpeng
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-3.2.0-2.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-02 00:05:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
libvirtd.log on source and target host, qemu log on target host
none
libvirtd.log on target host none

Description yafu 2017-04-05 10:03:15 UTC
Created attachment 1268910 [details]
libvirtd.log on source and target host, qemu log on target host

Description of problem:
Libvirtd can not report clear error when migration start but failed with some reason.

Version-Release number of selected component (if applicable):
libvirt-3.2.0-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Prepare guest xml with unix guest agent, and specify the socket path :
   <channel type='unix'>
      <source mode='bind' path='/test/agent'/>
      <target type='virtio' name='org.qemu.guest_agent.0'/>
      <address type='virtio-serial' controller='0' bus='0' port='2'/>
    </channel>

2.# mkdir /test

3. Change the owner and selinux context of the directory:
# chown qemu:qemu /test

# chcon system_u:object_r:qemu_var_run_t:s0 /test/

4. Define&start guest:
 # virsh define rhel7.3-min.xml
 # virsh start rhel7.3-min

5.Do migration:
# virsh migrate rhel7.3-min qemu+ssh://10.66.4.148/system --live --verbose --migrateuri tcp://10.66.4.148
root.4.148's password:
error: invalid argument: monitor must not be NULL

Actual results:
Migration failed with unclear error.

Expected results:
Migration failed with error:
error: internal error: process exited while connecting to monitor: 2017-04-05T05:43:26.542618Z qemu-kvm: -chardev socket,id=charchannel1,path=/test/agent,server,nowait: Failed to bind socket to /test/agent: No such file or directory


Additional info:
1.Check the libvirtd.log on source host, could see the migration has started;
2.The issue can also reproduced with other scenario, such as the source file not found on the target host;
3.It works well with libvirt-3.1.0-2.el7.x86_64

Comment 2 Jiri Denemark 2017-04-05 13:22:13 UTC
The most important log file "libvirtd.log-target" is empty...

Comment 3 yafu 2017-04-06 02:54:17 UTC
Created attachment 1269160 [details]
libvirtd.log on target host

Comment 4 yafu 2017-04-06 02:59:36 UTC
(In reply to Jiri Denemark from comment #2)
> The most important log file "libvirtd.log-target" is empty...

Sorry, I uploaded the libivrtd.log on target host again.

Comment 5 Jiri Denemark 2017-04-06 07:59:02 UTC
This is caused by the code which resets TLS parameters at the end of migration. Patch sent upstream for review: https://www.redhat.com/archives/libvir-list/2017-April/msg00267.html

Comment 6 Jiri Denemark 2017-04-07 13:34:48 UTC
Fixed upstream by

commit 45b639bdbabe59056a6fc89ee4189fe695d6fae2
Refs: v3.2.0-78-g45b639bdb
Author:     Jiri Denemark <jdenemar>
AuthorDate: Thu Apr 6 09:23:18 2017 +0200
Commit:     Jiri Denemark <jdenemar>
CommitDate: Fri Apr 7 13:43:37 2017 +0200

    qemu: Don't overwrite existing error in qemuMigrationReset

    https://bugzilla.redhat.com/show_bug.cgi?id=1439130

    Signed-off-by: Jiri Denemark <jdenemar>

Comment 9 yafu 2017-05-05 03:41:37 UTC
Reproduced with libvirt-3.2.0-1.el7.x86_64.

Verified pass with libvirt-3.2.0-3.el7.x86_64

Test steps are as comment 0.

Comment 10 errata-xmlrpc 2017-08-02 00:05:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846

Comment 11 errata-xmlrpc 2017-08-02 01:30:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846