Bug 1439354

Summary: Auto_placement provision in Redhat domain fails due to selecting Host in Maintenance state.
Product: Red Hat CloudForms Management Engine Reporter: William Fitzgerald <wfitzger>
Component: ProvisioningAssignee: William Fitzgerald <wfitzger>
Status: CLOSED CURRENTRELEASE QA Contact: Alex Newman <anewman>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 5.7.0CC: jhardy, lkhomenk, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: provision
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1443081 (view as bug list) Environment:
Last Closed: 2018-03-06 15:41:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1443081    

Description William Fitzgerald 2017-04-05 19:10:51 UTC 
Description of problem:Environment setup - best fitting Host in Maintenance mode should not be selected

All methods in /RedHat/Infrastructure/VM/Provisioning/Placement/
1. redhat_best_placement_with_scope
2. vmware_best_fit_with_scope
3. vmware_best_fit_with_tags

Version-Release number of selected component (if applicable):

How reproducible:100%

Steps to Reproduce:
1.Prepare env
2.Provision VM with auto_placement.
3.Put selected host in maintennace mode.
4.Provision VM with auto_placement using host in maintennace mode.

Actual results: "Maintenance" Host could be selected and then provision will fail.

Expected results: "Maintenance" Host should not be selected.
Comment 2 CFME Bot 2017-04-17 19:12:51 UTC 
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=077b0f8a433d892365027be06cc04c680d8e3944

commit 077b0f8a433d892365027be06cc04c680d8e3944
Author:     william fitzgerald <wfitzger>
AuthorDate: Wed Apr 5 16:46:47 2017 -0400
Commit:     william fitzgerald <wfitzger>
CommitDate: Wed Apr 5 16:46:47 2017 -0400

    Modified 3 placement methods to not select Hosts in maintenance mode.
    
    Added a check for maintenance in all 3 methods.
    1. redhat_best_placement_with_scope
    2. vmware_best_fit_with_scope
    3. vmware_best_fit_with_tags
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1439354

 .../Placement.class/__methods__/redhat_best_placement_with_scope.rb      | 1 +
 .../Placement.class/__methods__/vmware_best_fit_with_scope.rb            | 1 +
 .../Placement.class/__methods__/vmware_best_fit_with_tags.rb             | 1 +
 3 files changed, 3 insertions(+)
Comment 3 CFME Bot 2017-04-17 19:12:55 UTC 
New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=41869db023ed01ed5bacd57b03469035a60d2cde

commit 41869db023ed01ed5bacd57b03469035a60d2cde
Merge: 0a338bf 077b0f8
Author:     Jason Frey <jfrey>
AuthorDate: Mon Apr 17 15:11:59 2017 -0400
Commit:     Jason Frey <jfrey>
CommitDate: Mon Apr 17 15:11:59 2017 -0400

    Merge branch 'host_maint' into 'master'
    
    Modified 3 placement methods to not select Hosts in maintenance mode.
    
    Added a check for maintenance in all 3 methods.
    1. redhat_best_placement_with_scope
    2. vmware_best_fit_with_scope
    3. vmware_best_fit_with_tags
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1439354
    
    See merge request !448

 .../Placement.class/__methods__/redhat_best_placement_with_scope.rb      | 1 +
 .../Placement.class/__methods__/vmware_best_fit_with_scope.rb            | 1 +
 .../Placement.class/__methods__/vmware_best_fit_with_tags.rb             | 1 +
 3 files changed, 3 insertions(+)