Bug 1439532

Summary: Container Review Request - postgresql - Advanced Object-Relational database management system
Product: [Fedora] Fedora Container Images Reporter: Pavel Raiskup <praiskup>
Component: Container ReviewAssignee: Honza Horak <hhorak>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: container-review, hhorak, praiskup
Target Milestone: ---Flags: hhorak: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-19 12:36:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1436796    

Description Pavel Raiskup 2017-04-06 08:05:13 UTC 
Container Build Info URL: https://praiskup.fedorapeople.org/reviews/docker/postgresql
Temporary git: https://github.com/praiskup/fedora-postgresql-container
Description:
PostgreSQL is an advanced Object-Relational database management system (DBMS).
The image contains the client and server programs that you'll need to
create, run, maintain and access a PostgreSQL DBMS server.
Fedora Account System Username: praiskup

Additional info:
This is import from sclorg/postgresql-container, rather than from previous
Fedora container "upstream" tracked in Fedora-Dockerfiles.  This decision
was made to better align 'postgresql' term in Fedora container world with
'postgresql' in CentOS/RHEL container world.  I'll try to move the former
'fedora/postgersql' image to different namespace once I'll have a bit of time
and I'll submit new merge review.
Comment 1 Honza Horak 2017-04-07 10:57:24 UTC 
Great, I'll take a look at this as a reviewer.
Comment 2 Pavel Raiskup 2017-04-07 13:24:16 UTC 
For anybody who is familiar with sclorg's postgresql-container (Honza e.g.),
you can have a look at [1] change against [2].

[1] https://github.com/praiskup/fedora-postgresql-container/commit/d27bff8e63739dd0
[2] sclorg/postgresql-container, commit 2f9f70c (directory 9.4)
Comment 3 Honza Horak 2017-04-07 14:30:24 UTC 
The compulsory labels are missing [1]:
BZComponent, Name, Version, Release, Architecture, Usage, Help

The FROM now must include registry name [2]:
FROM registry.fedoraproject.org/fedora:25

[1] https://fedoraproject.org/wiki/Container:Guidelines#FROM
[2] https://fedoraproject.org/wiki/Container:Guidelines#LABELS

Otherwise it looks good to me.
Comment 4 Pavel Raiskup 2017-04-12 12:00:57 UTC 
Container Build Info URL: https://praiskup.fedorapeople.org/reviews/docker/postgresql

Change:
https://github.com/praiskup/fedora-postgresql-container/commit/6b25ab3ec8d079062298c03994c963d0c3e92382
Comment 5 Honza Horak 2017-04-18 10:05:15 UTC 
Looks good to me now, thanks.
Comment 6 Pavel Raiskup 2017-04-19 12:08:36 UTC 
PKGDB requests:
https://admin.fedoraproject.org/pkgdb/package/requests/11710
https://admin.fedoraproject.org/pkgdb/package/requests/11711
https://admin.fedoraproject.org/pkgdb/package/requests/11712
Comment 7 Gwyn Ciesla 2017-04-19 12:13:54 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/postgresql
Comment 8 Pavel Raiskup 2017-04-19 12:36:33 UTC 
F25 build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19078629