Bug 1440147

Summary:	Failed builds delay start of next build + don't have a completion time
Product:	OpenShift Container Platform	Reporter:	Ben Parees <bparees>
Component:	Build	Assignee:	Ben Parees <bparees>
Status:	CLOSED ERRATA	QA Contact:	Wenjing Zheng <wzheng>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.5.0	CC:	aos-bugs, cewong, tdawson
Target Milestone:	---	Keywords:	UpcomingRelease
Target Release:	3.5.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cdaley@redhat.com	Doc Type:	Bug Fix
Doc Text:	Cause: With the serial policy, the failure of a build was not triggering the logic to check for the next build to run. Consequence: After a failed build, a delay of up to 2 minutes could occur before the next build would start, when using a serial build policy. Fix: Trigger the next build immediately after a build fails, as is done with cancelled and successful builds. Result: The next build will start immediately after a build fails (or otherwise completes).	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-26 05:36:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ben Parees 2017-04-07 11:53:49 UTC

Description of problem:
When multiple builds are queued and the running build fails, the next build is not always started immediately, and the failed build does not get its completion time/duration set properly.



Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. define a buildconfig that will fail to build (e.g. points to an invalid source repository)
2. start 4 builds
3. watch the builds, observe that when the first build fails, the next build does not necessarily start immediately.
4. oc describe the failed build, observe that the duration reports that the build is "waiting for Xs" and X continues to change each time oc describe is run.


Actual results:
See above (step 3, 4).


Expected results:
next build should start immediately, build should report a fixed duration based on how long it actually took to run.

Comment 1 Ben Parees 2017-04-07 14:26:23 UTC

PR https://github.com/openshift/origin/pull/13670

Comment 3 Troy Dawson 2017-04-18 20:09:33 UTC

This has been merged into ocp and is in OCP v3.5.5.7 or newer.

Comment 5 Wenjing Zheng 2017-04-19 06:02:31 UTC

When previous build fail, the following one start immediately, so moving this bug to verified on OCP 3.5.5.7:
[wzheng@openshift-qe work]$ oc get builds --watch
NAME                   TYPE      FROM          STATUS                            STARTED          DURATION
s2i-httpd-example-11   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   29 seconds ago   3s
s2i-httpd-example-12   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   22 seconds ago   2s
s2i-httpd-example-13   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   16 seconds ago   2s
s2i-httpd-example-14   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   12 seconds ago   3s
s2i-httpd-example-15   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   7 seconds ago    3s
s2i-httpd-example-16   Source    Git           Pending                                            
s2i-httpd-example-17   Source    Git           New                                                
NAME                   TYPE      FROM      STATUS    STARTED        DURATION
s2i-httpd-example-16   Source    Git       Running   1 second ago   
s2i-httpd-example-16   Source    Git@eaa1387   Running   2 seconds ago   
s2i-httpd-example-16   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   2 seconds ago   
s2i-httpd-example-16   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   3 seconds ago   2s
s2i-httpd-example-17   Source    Git       New                 
s2i-httpd-example-17   Source    Git       Pending             
s2i-httpd-example-17   Source    Git       Running   2 seconds ago   
s2i-httpd-example-17   Source    Git@eaa1387   Running   4 seconds ago   
s2i-httpd-example-17   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   5 seconds ago   
s2i-httpd-example-17   Source    Git@eaa1387   Failed (PullBuilderImageFailed)   6 seconds ago   4s

Comment 7 errata-xmlrpc 2017-04-26 05:36:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1129