Bug 1440290

Summary: RFE: cinder-dellsc.yaml missing several values
Product: Red Hat OpenStack Reporter: Chris Paquin <cpaquin>
Component: openstack-tripleo-heat-templatesAssignee: Alan Bishop <abishop>
Status: CLOSED ERRATA QA Contact: Avi Avraham <aavraham>
Severity: medium Docs Contact:
Priority: medium    
Version: 10.0 (Newton)CC: aavraham, abishop, aschultz, jjoyce, mburns, pgrist, rhel-osp-director-maint, samccann, scohen, tshefi
Target Milestone: z4Keywords: FutureFeature, Triaged, ZStream
Target Release: 10.0 (Newton)Flags: scohen: needinfo+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-5.2.0-24.el7ost, puppet-tripleo-5.6.0-5.el7ost, puppet-cinder-9.5.0-2.el7ost Doc Type: Bug Fix
Doc Text:
Cause: TripleO does not support several parameters required by the Dell EMC SC cinder backend driver. The driver parameters are associated with the Dell EMC SC's "exclude_domain_ip" and "secondary DSM" features. Consequence: The Dell EMC SC driver parameters are not configured by TripleO, and a post-deploy script is required to patch them into the cinder configuration. Fix: TripleO Heat Template parameters have been defined for all the missing parameters, and the Puppet modules have been updated to set the parameters in the cinder driver configuration. Result: TripleO supports setting the Dell EMC SC parameters associated with the cinder driver's "exclude_domain_ip" and "secondary DSM" features.
 Story Points: ---
Clone Of:
: 1464197 (view as bug list) Environment:
Last Closed: 2017-09-06 17:09:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1464197    
Bug Blocks:    

Description Chris Paquin 2017-04-07 19:34:46 UTC 
Description of problem:

Customer has been advised by dell that there are additional configuration values required when deploying dell sc storage, however these values are not in cinder-dellsc.yaml


Version-Release number of selected component (if applicable):

OSP10

Default configuration values.

parameter_defaults:
  CinderEnableDellScBackend: true
  CinderDellScBackendName: 'tripleo_dellsc'
  CinderDellScSanIp: '10.75.15.126'
  CinderDellScSanLogin: 'Admin'
  CinderDellScSanPassword: 'PASSWORD1'
  CinderDellScSsn: '62066'
  CinderDellScIscsiIpAddress: '172.20.9.100'
  CinderDellScIscsiPort: '3260'
  CinderDellScApiPort: '3033'
  CinderDellScServerFolder: 'volname'
  CinderDellScVolumeFolder: 'volname'

However customer has been advised by Dell to add additional params to /etc/cinder/cinder.conf via a post deploy script. These values are below. excluded_domain_ip is present twice as an apparent workaround related to discovery when configuring multiple faults (see https://bugs.launchpad.net/cinder/+bug/1616499) 


excluded_domain_ip 172.20.25.15
excluded_domain_ip 172.20.33.15
secondary_san_ip 10.75.15.125
secondary_san_password PASSWORD2
secondary_san_login Admin
secondary_sc_api_port 3033


Reference:

See https://github.com/openstack/tripleo-heat-templates/blob/master/environments/cinder-dellsc-config.yaml

and https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/cinder-backend-dellsc.yaml
Comment 2 Alan Bishop 2017-05-24 14:22:25 UTC 
Changes like this are conceptually simple, but awkward because they involve patches in 3 different components (tripleo-heat-templates, puppet-tripleo and puppet-cinder). Looking upstream, I see puppet-tripleo and puppet-cinder changes are on master, and there's reasonable expectation they would be accepted on stable/ocata. They would need to be back ported to RHOS-10. The tripleo-heat-templates change has not yet been accepted on master, but will probably land there soon. It will also need to be proposed to stable/ocata and back ported to RHOS-10. (I'll add the upstream reviews to the BZ).
Comment 3 Alan Bishop 2017-05-24 14:34:00 UTC 
To clarify, it seems the upstream changes are split into two chunks; one for the four "secondary_" parameters and one for the excluded_domain_ip. The first chunk is on master, and the second is still in progress. The gerrit reviews I added are for the excluded_domain_ip parameter. So it seems a total of six patches will need to be proposed to stable/ocata, and the same six back ported to RHOS-10.
Comment 9 Tzach Shefi 2017-08-15 12:34:07 UTC 
Verified on
openstack-tripleo-heat-templates-5.3.0-2.el7ost.noarch
puppet-tripleo-5.6.1-1.el7ost.noarch
puppet-cinder-9.5.0-2.el7ost.noarch

Checked both files:
/usr/share/openstack-puppet/modules/tripleo/manifests/profile/base/cinder/volume/dellsc.pp

/usr/share/openstack-tripleo-heat-templates/puppet/services/cinder-backend-dellsc.yaml cinder-backend-dellsc.yaml

All the fixes are in. 
I don't have access to a Dell SC system to test actual deployment. 

Clearing needinfos on people.
Comment 12 errata-xmlrpc 2017-09-06 17:09:30 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2654