Bug 1440384

Output from fedora-review:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "SIL (v1.1)", "LGPL (v2 or later)", "GPL (v2 or later)",
     "Unknown or generated". 83 files have unknown license. Detailed output
     of licensecheck in /home/marc/rpmbuild/SPECS/Latte-
     Dock/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/icons/hicolor/22x22/apps(Latte-Dock, hicolor-icon-theme,
     fedora-logos, luma), /usr/share/icons/breeze/applets(breeze-icon-
     theme, Latte-Dock), /usr/share/icons/hicolor/32x32/apps(Latte-Dock,
     hicolor-icon-theme, fedora-logos, keepassx, luma),
     /usr/share/icons/hicolor/24x24/apps(Latte-Dock, hicolor-icon-theme,
     fedora-logos, keepassx), /usr/share/locale/es/LC_MESSAGES(Latte-Dock,
     filesystem), /usr/share/plasma/shells(Latte-Dock, plasma-desktop),
     /usr/share/icons/hicolor/24x24(Latte-Dock, hicolor-icon-theme, fedora-
     logos, keepassx), /usr/share/locale/it/LC_MESSAGES(Latte-Dock,
     filesystem), /usr/share/applications(Latte-Dock, filesystem),
     /usr/share/icons(Latte-Dock, luma, filesystem),
     /usr/share/dbus-1/interfaces(Latte-Dock, dbus), /usr/share/locale/de
     (Latte-Dock, filesystem), /usr/share/icons/breeze(breeze-icon-theme,
     Latte-Dock), /usr/share/kservices5(Latte-Dock, kf5-kservice,
     kf5-filesystem), /usr/share/locale/pl/LC_MESSAGES(Latte-Dock,
     filesystem), /usr/share/locale/de/LC_MESSAGES(Latte-Dock, filesystem),
     /usr/lib64/qt5/qml/org(Latte-Dock, kf5-plasma, kf5-knewstuff,
     kf5-kirigami2, kf5-kdeclarative, kf5-kirigami), /usr/share/plasma
     (Latte-Dock, kf5-plasma, f25-backgrounds-kde),
     /usr/share/plasma/plasmoids(Latte-Dock, plasma-desktop, kf5-plasma,
     plasma-workspace), /usr/share/icons/hicolor/16x16(Latte-Dock, hicolor-
     icon-theme, fedora-logos, keepassx, luma),
     /usr/share/icons/hicolor/48x48/apps(Latte-Dock, hicolor-icon-theme,
     fedora-logos, keepassx, luma), /usr/share/icons/hicolor/scalable/apps
     (Latte-Dock, hicolor-icon-theme, fedora-logos, keepassx, luma),
     /usr/share/knotifications5(Latte-Dock, kf5-knotifications),
     /usr/share/icons/hicolor(Latte-Dock, hicolor-icon-theme, fedora-logos,
     luma), /usr/share/locale/el/LC_MESSAGES(Latte-Dock, filesystem),
     /usr/share/locale/es(Latte-Dock, filesystem), /usr/share/dbus-1(Latte-
     Dock, dbus), /usr/share/locale/ro/LC_MESSAGES(Latte-Dock, filesystem),
     /usr/share/locale/el(Latte-Dock, filesystem), /usr/share/locale/it
     (Latte-Dock, filesystem), /usr/share/appdata(Latte-Dock, filesystem),
     /usr/share/icons/hicolor/32x32(Latte-Dock, hicolor-icon-theme, fedora-
     logos, keepassx, luma), /usr/share/locale/zh_TW/LC_MESSAGES(Latte-
     Dock, filesystem), /usr/share/icons/hicolor/16x16/apps(Latte-Dock,
     hicolor-icon-theme, fedora-logos, keepassx, luma),
     /usr/share/locale/ro(Latte-Dock, filesystem),
     /usr/share/icons/hicolor/22x22(Latte-Dock, hicolor-icon-theme, fedora-
     logos, keepassx, luma), /usr/lib64/qt5/qml/org/kde(Latte-Dock,
     kf5-plasma, kf5-knewstuff, kf5-kirigami2, kf5-kdeclarative,
     kf5-kirigami), /usr/share/locale/pl(Latte-Dock, filesystem),
     /usr/share/icons/hicolor/48x48(Latte-Dock, hicolor-icon-theme, fedora-
     logos, keepassx, luma), /usr/share/icons/breeze/applets/256(breeze-
     icon-theme, Latte-Dock), /usr/share/locale/zh_TW(Latte-Dock,
     filesystem), /usr/share/locale(Latte-Dock, filesystem),
     /usr/share/icons/hicolor/scalable(Latte-Dock, hicolor-icon-theme,
     fedora-logos, keepassx, luma)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
     contains icons.
     Note: icons in Latte-Dock
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[ ]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in Latte-
     Dock-debuginfo
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1146880 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Update:

- Removed DCMAKE_INSTALL_PREFIX=%{_usr} as is set already by the macro %{cmake_kf5}
- Added a comment to make obvious the desktop-file-validate is unneeded for some files

Thanks Rex Dieter for the recommendations

Update:

Following Rex's recommendation, removed the desktop-file-validate as it might lead to false positives

I can formally review this soon.

As mentioned on irc, but for full disclosure:

whenever you make package changes, always bump Release and add %changelog entry... even for reviews (especially! for reviews).

Updated the package to latest version:

Spec URL: https://marcdeop.fedorapeople.org/Latte-Dock.spec
SRPM URL: https://marcdeop.fedorapeople.org/Latte-Dock-0.6.1-1.fc25.src.rpm

Yet another update:

Spec URL: https://marcdeop.fedorapeople.org/Latte-Dock.spec
SRPM URL: https://marcdeop.fedorapeople.org/Latte-Dock-0.6.2-1.fc25.src.rpm

Sorry for the extended delay...


naming:

1.  SHOULD consider naming in lower case, see also
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines


dependencies:
2.  MUST: Document the need for explicit library depenedencies:
Requires:       libxcb
Requires:       xcb-util
Requires:       qt5-qtx11extras
(I'm guessing these may not really be needed)

See also:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Explicit_Requires


3.  SHOULD drop deprecated stuff:
%clean
(the %clean section can be removed altogether)

(in %files)
%defattr...

(in %install section)
%{__rm} -rf %{buildroot}


4. SHOULD not use %{make_install}, which is intended for autotools-based projects mostly, I suggest changing
%{make_install} DESTDIR=%{buildroot} -C build
to
make install/fast DESTDIR=%{buildroot} -C build


5. MUST be more explicit in %%files, use %%find_lang, and use less globs, something like:

in %install section (after 'make install...'):
%find_lang %{name} --all-name

and in %files:

%files -f %{name}.lang
%{_bindir}/latte-dock
%{_kf5_datadir}/appdata/org.kde.latte.containment.appdata.xml
%{_kf5_datadir}/appdata/org.kde.latte.plasmoid.appdata.xml
%{_kf5_datadir}/appdata/org.kde.latte.shell.appdata.xml
%{_kf5_datadir}/applications/latte-dock.desktop
%{_kf5_datadir}/dbus-1/interfaces/org.kde.LatteDock.xml
%{_kf5_datadir}/icons/breeze/*/*/*
%{_kf5_datadir}/icons/hicolor/*/*/*
%{_kf5_datadir}/knotifications5/lattedock.notifyrc
%{_kf5_datadir}/kservices5/plasma-applet-org.kde.latte.containment.desktop
%{_kf5_datadir}/kservices5/plasma-applet-org.kde.latte.plasmoid.desktop
%{_kf5_datadir}/kservices5/plasma-shell-org.kde.latte.shell.desktop
%{_kf5_datadir}/plasma/plasmoids/org.kde.latte.containment/
%{_kf5_datadir}/plasma/plasmoids/org.kde.latte.plasmoid/
%{_kf5_datadir}/plasma/shells/org.kde.latte.shell/
%{_kf5_qmldir}/org/kde/latte/


6. %build section uses pushd, but there's no popd.  It's mostly harmless as is currently, but could cause problems later.  SHOULD add matching 'pop'd near end of %build section

licensing: ok

sources: ok
8b7f07a3ba2a9296d6d7f83d7e83e7d1  v0.6.2.tar.gz


Please address items 1-6

New update addressing Rex requests

Spec URL: https://marcdeop.fedorapeople.org/latte-dock.spec
SRPM URL: https://marcdeop.fedorapeople.org/latte-dock-0.6.2-2.fc25.src.rpm

I am not entirely sure what I did with the name is the right solution...

Looks good (name is fine), approved

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/latte-dock

https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ef6205e7c