Bug 1440787

*** Bug 1440723 has been marked as a duplicate of this bug. ***

 220       <packagereq arch="ppc64,ppc64le,x86_64">grub2</packagereq>
 221       <packagereq arch="aarch64,x86_64">grub2-efi</packagereq>

This is current situation, which we need to fix per arch

Peter can you help us with proper placement?

Thanks

This currently causes grub2* rpms to appear in optional

Lubos

This is my proposal

* 32bit rpms (multilib) still available but not installed by default (rather than having them in optional). 

* grub2-ppc64 default on ppc64 but optional on ppc64le 
* efi-64 and pc by default on intel

Seems like grub2-tools is pulled in via dependencies.

I'm making the commit now so we have installable nightly tree. Feel free to send other proposals.

lkocman@rcm-compose-nightly-01:~/comps$ git diff comps-rhel-7.4.xml.in
diff --git a/comps-rhel-7.4.xml.in b/comps-rhel-7.4.xml.in
index 792bf16..ad1b2a7 100644
--- a/comps-rhel-7.4.xml.in
+++ b/comps-rhel-7.4.xml.in
@@ -144,8 +144,15 @@
       <packagereq>fcoe-utils</packagereq>
       <packagereq>firewalld</packagereq>
       <packagereq arch="x86_64,s390x,ppc64le">gfs2-utils</packagereq>
-      <packagereq arch="ppc64,ppc64le,x86_64">grub2</packagereq>
-      <packagereq arch="aarch64,x86_64">grub2-efi</packagereq>
+      <packagereq type="optional" arch="ppc64">grub2-ppc</packagereq>
+      <packagereq type="optional" arch="ppc64le">grub2-ppc64</packagereq>
+      <packagereq type="default" arch="ppc64">grub2-ppc64</packagereq>
+      <packagereq type="default" arch="ppc64le">grub2-ppc64le</packagereq>
+      <packagereq type="optional" arch="x86_64">grub2-efi-ia32</packagereq>
+      <packagereq type="default" arch="x86_64">grub2-efi-x64</packagereq>
+      <packagereq type="default" arch="x86_64">grub2-pc</packagereq>
+      <packagereq type="default" arch="aarch64">grub2-efi-aa64</packagereq>
+      <packagereq type="optional" arch="ppc64le">grub2-ppc64</packagereq>
       <packagereq>iscsi-initiator-utils</packagereq>
       <packagereq>lvm2</packagereq>
       <packagereq>mdadm</packagereq>

I think actually that should be:

--- a/comps-rhel-7.4.xml.in
+++ b/comps-rhel-7.4.xml.in
@@ -144,8 +144,12 @@
       <packagereq>fcoe-utils</packagereq>
       <packagereq>firewalld</packagereq>
       <packagereq arch="x86_64,s390x,ppc64le">gfs2-utils</packagereq>
-      <packagereq arch="ppc64,ppc64le,x86_64">grub2</packagereq>
-      <packagereq arch="aarch64,x86_64">grub2-efi</packagereq>
+      <packagereq type="default" arch="ppc64">grub2-ppc64</packagereq>
+      <packagereq type="default" arch="ppc64le">grub2-ppc64le</packagereq>
+      <packagereq type="optional" arch="x86_64">grub2-efi-ia32</packagereq>
+      <packagereq type="optional" arch="x86_64">grub2-efi-x64</packagereq>
+      <packagereq type="optional" arch="x86_64">grub2-pc</packagereq>
+      <packagereq type="default" arch="aarch64">grub2-efi-aa64</packagereq>
       <packagereq>iscsi-initiator-utils</packagereq>
       <packagereq>lvm2</packagereq>
       <packagereq>mdadm</packagereq>

I'm not completely sure about the ppc bits, but it isn't obvious to me that grub2-ppc should ever be installed on grub2-ppc64le, etc.

On x86_64 grub2-efi-x64 and grub2-pc should actually both be optional, I think; they should not ever both be installed on the same machine.  Anaconda will pull the correct one in automatically based on the install type, so there doesn't strictly need to be a default at all.

All,

pbunyan adds Pegas kernel maintainer just so he is aware...

Doing slight change due fact that we've had *modules* spreaded across pungi config rather than comps. So adding modules as optional. And I agree about ppc being in optional as well.

<packagereq type="default" arch="ppc64">grub2-ppc64</packagereq>
<packagereq type="optional" arch="ppc64">grub2-ppc64-modules</packagereq>
<packagereq type="default" arch="ppc64le">grub2-ppc64le</packagereq>
<packagereq type="optional" arch="ppc64le">grub2-ppc64le-modules</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-ia32</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-ia32-modules</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-x64</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-x64-modules</packagereq>
<packagereq type="optional" arch="x86_64">grub2-pc</packagereq>
<packagereq type="default" arch="aarch64">grub2-efi-aa64</packagereq>
<packagereq type="optional" arch="aarch64">grub2-efi-aa64-modules</packagereq>

aarch64 is still broken with Pegas-7.4-20170411.n.0 with the same traceback from duplicate bug 1440723 comment 0
  https://beaker.engineering.redhat.com/recipes/3722566#installation

ppc64le is still broken with Pegas-7.4-20170411.n.0 with the same traceback from duplicate bug 1440723 comment 11
  https://beaker.engineering.redhat.com/recipes/3722568#installation

x86_64 worked ok
  https://beaker.engineering.redhat.com/recipes/3722567#installation

s390x finished the kickstart and rebooted, but it failed on first boot and dropped into the dracut emergency shell
  https://beaker.engineering.redhat.com/recipes/3722569#installation

s390x issue is caused by systemd, bug 1274401

ppc64le and aarch64 tracebacks are caused by a bug in anaconda, to be addressed with https://github.com/rhinstaller/anaconda/pull/1023 .  I'm told there will be builds on 12-Apr-2017.  In the mean time, I've done this scratch build that you should be able to test with: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12994741

Combined with this grub2 build to fix the package naming issue WRT different arch targets, that should get you a long way I think: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12994084

And with those, I think the comps change mentioned above becomes:

--- a/comps-rhel-7.4.xml.in
+++ b/comps-rhel-7.4.xml.in
@@ -144,8 +144,10 @@
       <packagereq>fcoe-utils</packagereq>
       <packagereq>firewalld</packagereq>
       <packagereq arch="x86_64,s390x,ppc64le">gfs2-utils</packagereq>
       <packagereq arch="ppc64,ppc64le,x86_64">grub2</packagereq>
-      <packagereq arch="aarch64,x86_64">grub2-efi</packagereq>
+      <packagereq type="optional" arch="x86_64">grub2-efi-ia32</packagereq>
+      <packagereq type="optional" arch="x86_64">grub2-efi-x64</packagereq>
+      <packagereq type="default" arch="aarch64">grub2-efi-aa64</packagereq>
       <packagereq>iscsi-initiator-utils</packagereq>
       <packagereq>lvm2</packagereq>
       <packagereq>mdadm</packagereq>

Aaand those builds will really be:

grub2-2.02-0.56.el7 https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12994939
anaconda-21.48.22.108-1.el7.pj0 https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12995225

(In reply to Peter Jones from comment #13)
> And with those, I think the comps change mentioned above becomes:
> 
> --- a/comps-rhel-7.4.xml.in
> +++ b/comps-rhel-7.4.xml.in
> @@ -144,8 +144,10 @@
>        <packagereq>fcoe-utils</packagereq>
>        <packagereq>firewalld</packagereq>
>        <packagereq arch="x86_64,s390x,ppc64le">gfs2-utils</packagereq>
>        <packagereq arch="ppc64,ppc64le,x86_64">grub2</packagereq>
> -      <packagereq arch="aarch64,x86_64">grub2-efi</packagereq>
> +      <packagereq type="optional" arch="x86_64">grub2-efi-ia32</packagereq>
> +      <packagereq type="optional" arch="x86_64">grub2-efi-x64</packagereq>
> +      <packagereq type="default" arch="aarch64">grub2-efi-aa64</packagereq>
>        <packagereq>iscsi-initiator-utils</packagereq>
>        <packagereq>lvm2</packagereq>
>        <packagereq>mdadm</packagereq>

Actually I'm still not sure about this, because I don't know what repo it comes from.  Is this the part that's saying if it's landing in Server-optional or Server?  If so, these all need to be "default".

Added also legacy package as default (hopefully it's meant to be installed)
<packagereq arch="x86_64,s390x,ppc64,ppc64le" type="default">grub2</packagereq>
<packagereq type="default" arch="ppc64">grub2-ppc64</packagereq>
<packagereq type="optional" arch="ppc64">grub2-ppc64-modules</packagereq>
<packagereq type="default" arch="ppc64le">grub2-ppc64le</packagereq>
<packagereq type="optional" arch="ppc64le">grub2-ppc64le-modules</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-ia32</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-ia32-modules</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-x64</packagereq>
<packagereq type="optional" arch="x86_64">grub2-efi-x64-modules</packagereq>
<packagereq type="optional" arch="x86_64">grub2-pc</packagereq>
<packagereq type="default" arch="aarch64">grub2-efi-aa64</packagereq>
<packagereq type="optional" arch="aarch64">grub2-efi-aa64-modules</packagereq>

The way I'm looking on optional vs default is should package be installed by default. And then won't it be already pulled in by other package (we might skip comps record completely)?
 
Side effect is that group will appear as installed even when optional packages won't be.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1850