Bug 1440810

Summary:	Update rfc.sh to check Change-Id consistency for backports
Product:	[Community] GlusterFS	Reporter:	Shyamsundar <srangana>
Component:	scripts	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs, gluster-infra, nigelb, srangana
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.12	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1428047	Environment:
Last Closed:	2017-05-29 04:58:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1440754

Description Shyamsundar 2017-04-10 14:09:43 UTC

+++ This bug was initially created as a clone of Bug #1428047 +++

--- Additional comment from Worker Ant on 2017-04-05 16:53:12 EDT ---

REVIEW: https://review.gluster.org/17004 (scripts: Update rfc.sh to check existance of Change-Id in backports) posted (#1) for review on master by Shyamsundar Ranganathan (srangana)

--- Additional comment from Shyamsundar on 2017-04-05 16:58:39 EDT ---

The initial change to enforce/remind contributors to this requirement is to update rfc.sh. The commit in comment #2 is towards the same.

-----------------------

Cloning the rfc.sh changes part as a bug for 3.8.

Comment 1 Worker Ant 2017-04-10 14:24:13 UTC

REVIEW: https://review.gluster.org/17031 (scripts: Update rfc.sh to check existance of Change-Id in backports) posted (#1) for review on release-3.8 by Shyamsundar Ranganathan (srangana)

Comment 2 Worker Ant 2017-04-29 11:25:27 UTC

COMMIT: https://review.gluster.org/17031 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit ddf3d4d3785bbd4f964e54ebc72fd445662f21a5
Author: Shyam <srangana>
Date:   Wed Apr 5 14:22:57 2017 -0400

    scripts: Update rfc.sh to check existance of Change-Id in backports
    
    Addition to this script is a no-op on master.
    
    This would need to be backported to active release branches to be
    effective.
    
    This check is not smart proof, in that someone could proceed knowing
    that the Change-Id differs from master, but this is not expected to
    catch that, instead it is to serve more as a reminder that we need
    the same Change-Id across branches.
    
    Contributors not using rfc.sh would not see this, but they are few
    and possibly far in between. Also contributors using gerrit to
    cherry-pick changes will not see this. For both cases a server side
    solution to catch any changes are needed.
    
    There is a possiblilty that we will follow this up with a check
    on the gerrit end and add a comment to the reviews, to aid reviewers
    to quickly check the sanity of the Change-Id when it differs.
    
    > BUG: 1428047
    > Signed-off-by: Shyam <srangana>
    > Reviewed-on: https://review.gluster.org/17004
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    > Reviewed-by: Amar Tumballi <amarts>
    
    Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b
    BUG: 1440810
    Signed-off-by: Shyam <srangana>
    Reviewed-on: https://review.gluster.org/17031
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2017-05-29 04:58:58 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.12, please open a new bug report.

glusterfs-3.8.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2017-May/000072.html
[2] https://www.gluster.org/pipermail/gluster-users/