Bug 1440821

Summary:	Container Review Request: node.js - Platform for building and running node.js applications
Product:	[Fedora] Fedora Container Images	Reporter:	rpitonak
Component:	Container Review	Assignee:	Jan Koscielniak <jkosciel>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	26	CC:	container-review, hhorak, jkosciel
Target Milestone:	---	Flags:	jkosciel: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-16 10:04:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description rpitonak 2017-04-10 14:25:30 UTC

Dockerfile URL: https://github.com/container-images/nodejs/blob/master/6/Dockerfile
Other files URL: https://github.com/container-images/nodejs/tree/master/6

Description: This container image provides a platform for building and running Node.js application as a reproducible image using source-to-image. Node.js, as an asynchronous event driven JavaScript runtime, is designed to build scalable network applications.

Fedora Account System Username: rpitonak

Comment 1 Jan Koscielniak 2017-04-12 09:21:41 UTC

Hi,

I checked your Dockerfile and everything seems to be in order, except there was a recent change in the guidelines [1]. The "BZComponent" label is now a "com.redhat.component". Please fix that, otherwise the Dockerfile seems to be complying with the guidelines.

[1] https://fedoraproject.org/wiki/Container:Guidelines#LABELS

Comment 2 rpitonak 2017-04-12 09:59:22 UTC

Hi Jan,

Thanks for the review. It's now fixed.

Dockerfile URL: https://github.com/container-images/nodejs/blob/master/6/Dockerfile

Comment 3 Gwyn Ciesla 2017-04-21 13:09:50 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/nodejs

Comment 4 Honza Horak 2017-05-16 10:04:11 UTC

I believe this tracker can be closed. Feel free to re-open if it should be kept open for some reason.