Bug 1441560
| Summary: | "atomic storage modify --add-device" silently erases all images | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marius Vollmer <mvollmer> |
| Component: | atomic | Assignee: | smahajan <smahajan> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 26 | CC: | adimania, amurdaca, dwalsh, fkluknav, lsm5, walters |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | atomic-1.18.1-3.fc26 atomic-1.18.1-2.fc25 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-06-15 03:01:12 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marius Vollmer
2017-04-12 08:44:01 UTC
Once again, from a clean slate: # echo STORAGE_DRIVER=overlay2 >>/etc/sysconfig/docker-storage-setup # docker images REPOSITORY TAG IMAGE ID CREATED SIZE cockpit/base latest b9b9d906729a 2 days ago 287 MB docker.io/fedora 25 4daa661b467f 12 days ago 231 MB # atomic storage modify --add-device /dev/sda # systemctl restart docker # docker images REPOSITORY TAG IMAGE ID CREATED SIZE cockpit/base latest b9b9d906729a 2 days ago 287 MB docker.io/fedora 25 4daa661b467f 12 days ago 231 MB Thus, putting "STORAGE_DRIVER=overlay2" into /etc/sysconfig/docker-storage-setup causes container-storage-setup to do the right thing. That is correct, docker has moved it's default graph driver to overlay2. Taking a look into this one. Marius, thanks for pointing it out ! Shishir We have made STORAGE_DRIVER=overlay2 as default in container-storage-setup on some distributions. So I am wondering which Linux distribution are you on ? where devicemapper is still the default. Shishir (In reply to smahajan from comment #3) > We have made STORAGE_DRIVER=overlay2 as default in container-storage-setup > on some distributions. Ahh, that is great to hear. > So I am wondering which Linux distribution are you on > ? where devicemapper is still the default. This is on the not-yet-released Fedora 26. Package versions are in comment 0 above. Fedora 26 is supposed to default to overlay2 I just tried this on a fedora 27 (Server Edition) and overlay2 is the default. STEPS I did: 1) dnf remove docker. 2) rm -rf /var/lib/docker 3) rm /etc/sysconfig/docker-storage-setup and rm /etc/sysconfig/docker-storage I did steps (2) and (3) just to make sure I install on a clean slate. 4) dnf install docker. 5) systemctl start docker 6) cat /etc/sysconfig/docker-storage-setup >> STORAGE_DRIVER=overlay2 7) cat /etc/sysconfig/docker-storage >> DOCKER_STORAGE_OPTIONS="--storage-driver overlay2 " docker info is showing that docker is running on overlay2. Will try on Fedora 26 now. Shishir Please follow the steps in comment 0 when trying to reproduce this. Running "atomic storage modify --add-device /dev/somedev" is essential. (In reply to Daniel Walsh from comment #5) > Fedora 26 is supposed to default to overlay2 The docker daemon defaults to overlay2, but container-storage-setup defaults to devmapper. I guess the bug is that these two defaults are not in synch. (In reply to Marius Vollmer from comment #7) > Please follow the steps in comment 0 when trying to reproduce this. Running > "atomic storage modify --add-device /dev/somedev" is essential. Hmm, maybe it isn't. I didn't read comment 6 carefully enough... atomic-1.18.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d95fc1ce23 atomic-1.18.1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fd61a2effa atomic-1.18.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d95fc1ce23 atomic-1.18.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fd61a2effa atomic-1.18.1-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0db18f2e1 atomic-1.18.1-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0db18f2e1 atomic-1.18.1-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. atomic-1.18.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |