Bug 1441588
| Summary: | Review Request: copr-builder - build package from copr dist-git | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Raiskup <praiskup> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | clime, msuchy, package-review, sergey.avseyev |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | msuchy:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-05-27 23:25:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1400592 | ||
| Bug Blocks: | 1357562 | ||
|
Description
Pavel Raiskup
2017-04-12 09:35:58 UTC
Taking. > Summary: Build package from copr dist-git
Should be probably "Copr".
Can you mark LICENSE as %license in %files section? I.e.:
%license LICENSE
You should add:
Requires(pre): mock
otherwise it is possible that mock group does not exist yet when %_sharedstatedir/copr-builder is being copied.
Hmm having 7 sources is little bit akward to me. But definitelly allowed by guidelines so not a blocker. Just not so usual.
copr-builder has as shebang:
#! /bin/bash
The leading space... hmm it actually works! Never seen that.
You are using /var/lib/copr-builder/{pid,results,live-log}. You should own that directories.
And lock file as %ghost.
Spec URL: https://pagure.io/copr/copr/raw/bf1d7b1f3c61b5f2ca6573d8f4bb09b8478fc32f/f/builder/copr-builder.spec SRPM URL: http://praiskup.fedorapeople.org/copr-builder-0-13.fc25.src.rpm Thanks for the review. (In reply to Miroslav Suchý from comment #2) > You are using /var/lib/copr-builder/{pid,results,live-log}. You should > own that directories. And lock file as %ghost. This is the only thing I'm not sure about, the ownership of the files is not defined "in advance" (basically any user can create files under /var/lib/copr-builder, if in 'mock' group); so I had to use %verify macro && and thus %ghost doesn't give us a lot of added value. Also, other files under /var/lib/copr-builder are automatically created, without pre-defined filenames. > thus %ghost doesn't give us a lot of added value It give you value that `rpm -qf /var/lib/copr-builder/results` will give you hint which package is responsible for that directory. > Also, other > files under /var/lib/copr-builder are automatically created, without > pre-defined filenames. yes, but that does not mean we should give up even for filenames which we know about. Looks good now. Good work. APPROVED Thanks for the review, dist-git requests: https://admin.fedoraproject.org/pkgdb/package/requests/11879 https://admin.fedoraproject.org/pkgdb/package/requests/11880 https://admin.fedoraproject.org/pkgdb/package/requests/11881 https://admin.fedoraproject.org/pkgdb/package/requests/11882 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/copr-builder https://koji.fedoraproject.org/koji/taskinfo?taskID=19270764 https://koji.fedoraproject.org/koji/taskinfo?taskID=19270767 https://koji.fedoraproject.org/koji/taskinfo?taskID=19270789 https://koji.fedoraproject.org/koji/taskinfo?taskID=19270794 copr-builder-0-13.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4d24e2125 copr-builder-0-13.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e35771c05 copr-builder-0-13.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8e95d79227 copr-builder-0-13.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8e95d79227 copr-builder-0-13.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e35771c05 copr-builder-0-13.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4d24e2125 copr-builder-0-13.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. copr-builder-0-13.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. Would be nice to have manpage for the command. Automatically generated page could be a good start help2man --no-discard-stderr copr-builder Good idea, can you submit a separate bug-report for this? Note that fedora copr now uses different command (copr-rpmbuild). I just doing testing of the package on bodhi, and I thought it make sense to report it here, while the package still waiting there. Thanks, I just requested push. Sorry that it took that long. Anyways, I plan to update (and take care of) the package in future (since it has slightly nicer, build-id agnostic API -- and it might be convenient for end-users) - so any bugreport is worth it. Note though that it is likely that even the optional support for copr-builder will be removed from copr-backend. copr-builder-0-13.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |