Bug 1441719

Summary:	libosinfo fails to pick up the right audio device for Windows 7
Product:	[Community] Virtualization Tools	Reporter:	Felipe Borges <feborges>
Component:	libosinfo	Assignee:	Matthias Clasen <mclasen>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	berrange, cfergeau, crobinso, feborges, fidencio
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-29 17:10:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Felipe Borges 2017-04-12 14:31:36 UTC

Description of problem:
I see in osinfo-db/data/os/microsoft.com/win-7.xml.in that there's a <devices> entry for ich6.

But when I install an Windows 7 guest, it doesn't get picked. ac97 gets picked up instead, causing the guest to not have any valid audio output.

Editing the sound model entry with virsh edit <win-7-guest> fixes it.

This bug has been reported against GNOME Boxes.

Steps to Reproduce:
1. Install an Windows 7 guest
2. Play some sound
3.

Actual results:
There's no audio output.

Comment 1 Daniel Berrangé 2017-04-12 14:37:13 UTC

Does GNOME boxes have any logs that confirm that it actually correctly used the Win7 libosinfo data. eg i wonder if it picked the wrong OS version ? The latter could still be a libosinfo bug if, for example, we're missing a ISO image match rule to detect libosinfo.

Please also confirm what 'osinfo-db' version you have installed (or libosinfo version if your version pre-dates existance of osinfo-db RPM).

Comment 2 Felipe Borges 2017-04-18 09:29:39 UTC

(In reply to Daniel Berrange from comment #1)
> Does GNOME boxes have any logs that confirm that it actually correctly used
> the Win7 libosinfo data. eg i wonder if it picked the wrong OS version ?

That's it. The domain config for the Windows 10 (working) has the following metadata:

  <metadata>
    <boxes:gnome-boxes xmlns:boxes="https://wiki.gnome.org/Apps/Boxes">
      <os-state>installed</os-state>
      <os-id>http://microsoft.com/win/10</os-id>
      <media-id>http://microsoft.com/win/10:7</media-id>
      <media>/home/fborges/Downloads/en-gb_windows_10_multiple_editions_version_1703_updated_march_2017_x64_dvd_10194881.iso</media>
    </boxes:gnome-boxes>
  </metadata>

But the one version not working (Windows 7) has:

  <metadata>
    <boxes:gnome-boxes xmlns:boxes="https://wiki.gnome.org/Apps/Boxes">
      <os-state>installed</os-state>
      <media>/home/fborges/Downloads/en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso</media>
    </boxes:gnome-boxes>
  </metadata>

By using the osinfo-detect tool I obtain...

$ osinfo-detect en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso 
Media is bootable.
Media is an installer for OS 'Microsoft Windows 7 Professional'

Which makes me believe that this is not an osinfo bug. Is that right?

> Please also confirm what 'osinfo-db' version you have installed (or
> libosinfo version if your version pre-dates existance of osinfo-db RPM).

osinfo-db-20170326-1.fc26

Comment 3 Daniel Berrangé 2017-04-18 09:34:53 UTC

(In reply to Felipe Borges from comment #2)
> But the one version not working (Windows 7) has:
> 
>   <metadata>
>     <boxes:gnome-boxes xmlns:boxes="https://wiki.gnome.org/Apps/Boxes">
>       <os-state>installed</os-state>
>      
> <media>/home/fborges/Downloads/
> en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso</media>
>     </boxes:gnome-boxes>
>   </metadata>
> 
> By using the osinfo-detect tool I obtain...
> 
> $ osinfo-detect en_windows_7_professional_with_sp1_x64_dvd_u_676939.iso 
> Media is bootable.
> Media is an installer for OS 'Microsoft Windows 7 Professional'
> 
> Which makes me believe that this is not an osinfo bug. Is that right?

Yeah, that looks like a possible Boxes bug if it didn't match the ISO successfully, when osinfo-detect works. Other possibility is that there was an older libosinfo database present when Boxes did the initial OS install ?

Comment 4 Cole Robinson 2018-09-29 17:10:05 UTC

Yes it doesn't look like this is a libosinfo issue. Might have been fixed in boxes with this commit:

commit 5507e6f8c4d839c1037187e71664bbff38aac194
Author: Felipe Borges <felipeborges>
Date:   Fri Jan 12 12:48:40 2018 +0100

    vm-configurator: Use ICH6 as sound device fallback
    
    AC97 drivers are not available for win-8 nor win-10.
    
    We can fallback to ICH6, covering more unknown/undetected operating
    systems.
    
    Resolves #78