Bug 1441804 (kdb)
| Summary: | Review Request: kdb - Database Connectivity and Creation Framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-06-27 00:32:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1441801, 1441805 | ||
|
Description
Rex Dieter
2017-04-12 18:25:12 UTC
Sample/test builds in copr (since there are several that depend on each other): https://copr.fedorainfracloud.org/coprs/rdieter/calligra3 > BuildRequires: python Shouldn't this by python2 or python3 instead? If any version is OK, maybe add a comment. > # sqlite driver included in base (for now) > %{_qt5_plugindir}/kdb3/kdb_sqlitedriver.so Maybe add Provides: %{name}-driver-sqlite%{?_isa} = %{name}-%{version} so that it's easier to split out in the future? (Other packages can use R:%{name}-driver-sqlite w/o worrying about the potential future split.) http://community.kde.org/KDb → https:// http://download.kde.org/stable/ → https:// + package name is OK + licence is acceptable for Fedora (LGPLv2+) + license is specified correctly (docs seems to have a different license, but they're not in any of the binary packages, so irrelevant.) + builds and installs OK + P/R/BR look correct + scriptlets follow the guidelines + fedora-review finds no issues I didn't test the upgrade paths, but the Provides/Obsoletes seems all good. Rpmlint (installed packages) ---------------------------- kdb-driver-postgresql.x86_64: W: obsolete-not-provided koffice-kexi-driver-pgsql kdb.x86_64: W: obsolete-not-provided calligra-kexi-driver-sybase kdb.x86_64: W: obsolete-not-provided calligra-kexi-driver-xbase kdb-driver-mysql.x86_64: W: obsolete-not-provided koffice-kexi-driver-mysql OK. kdb-driver-postgresql.x86_64: W: no-documentation kdb-driver-postgresql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb-driver-postgresql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb-devel.x86_64: W: only-non-binary-in-usr-lib kdb-devel.x86_64: W: no-documentation kdb.x86_64: W: no-documentation kdb.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb.x86_64: W: no-manual-page-for-binary kdb3_sqlite3_dump kdb-driver-mysql.x86_64: W: no-documentation kdb-driver-mysql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb-driver-mysql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id All OK. kdb.x86_64: W: incoherent-version-in-changelog 3.0.1-0.1 ['3.0.1-1.fc27', '3.0.1-1'] Please fix. kdb.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKDb3.so.3.0 /lib64/libm.so.6 kdb.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKDb3.so.3.0 /lib64/libgcc_s.so.1 kdb.x86_64: W: shared-lib-calls-exit /usr/lib64/libKDb3.so.3.0 exit.5 Might be worth cleaning up at some point... 5 packages and 0 specfiles checked; 0 errors, 20 warnings. Package is APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdb kdb-3.0.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-57ab847ef7 kdb-3.0.1-1.fc26 kexi-3.0.1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-57ab847ef7 kdb-3.0.1-1.fc26, kexi-3.0.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-57ab847ef7 kdb-3.0.1-1.fc26, kexi-3.0.1-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |