Bug 1441922

Summary: logging can't be deployed by openshift-logging.yml playbook
Product: OpenShift Container Platform Reporter: Xia Zhao <xiazhao>
Component: InstallerAssignee: Russell Teague <rteague>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 3.5.0CC: anli, aos-bugs, jokerman, jswensso, juzhao, lizhou, mmccomas, rteague, tdawson
Target Milestone: ---   
Target Release: 3.5.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: The "OpenShift Aggregated Logging" play called the oo_first_master host group. However, the the evaluate_groups.yml was not included prior to the play. Consequence: The oo_first_master host group was not created therefore the entire play was skipped and logging was not installed. Fix: Added an include for evaluate_groups.yml to create the required host groups. Result: OpenShift Aggregated Logging is installed as expected.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-25 17:43:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Xia Zhao 2017-04-13 05:52:42 UTC 
Description of problem:
logging can't be deployed by usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/openshift-logging.yml. 
The root cause is there isn't oo_first_master group. it should add common/openshift-cluster/evaluate_groups.yml in front of common/openshift-cluster/openshift_logging.yml.

Version-Release number of selected component (if applicable):
openshift-ansible-3.5.53-1.git.0.8ade9f2.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. preparing  inventory file following https://docs.openshift.com/container-platform/3.5/install_config/aggregate_logging.html#aggregate-logging-ansible-variables
2. run playbook following https://docs.openshift.com/container-platform/3.5/install_config/aggregate_logging.html#deploying-the-efk-stack
  ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/openshift-logging.yml
2. check resource of project logging
   
Actual results:
No resouce is deployed under project logging.


Expected results:

Additional info:
Add common/openshift-cluster/evaluate_groups.yml in openshift-logging.yml as following.

+ - include: ../../common/openshift-cluster/evaluate_groups.yml
+  vars:
+    g_new_master_hosts: []
+    g_new_node_hosts: []
+    openshift_cluster_id: "{{ cluster_id | default('default') }}"
+    openshift_deployment_type: "{{ deployment_type }}"

- include: ../../common/openshift-cluster/openshift_logging.yml
  vars:
    openshift_cluster_id: "{{ cluster_id | default('default') }}"
    openshift_debug_level: "{{ debug_level | default(2) }}"
    openshift_deployment_type: "{{ deployment_type }}"
Comment 1 Russell Teague 2017-04-17 19:45:43 UTC 
Proposed: https://github.com/openshift/openshift-ansible/pull/3939
Comment 4 Russell Teague 2017-04-18 12:33:53 UTC 
Merged https://github.com/openshift/openshift-ansible/pull/3939
Comment 5 Troy Dawson 2017-04-18 20:11:06 UTC 
This has been merged into openshift-ansible and is in openshift-ansible-3.5.55 or newer.
Comment 7 Junqi Zhao 2017-04-19 01:10:56 UTC 
Testing passed by using openshift-ansible-3.5.55-1 and playbooks/byo/openshift-cluster/openshift-logging.yml

# rpm -qa | grep openshift-ansible
openshift-ansible-callback-plugins-3.5.55-1.git.0.29802ee.el7.noarch
openshift-ansible-docs-3.5.55-1.git.0.29802ee.el7.noarch
openshift-ansible-filter-plugins-3.5.55-1.git.0.29802ee.el7.noarch
openshift-ansible-lookup-plugins-3.5.55-1.git.0.29802ee.el7.noarch
openshift-ansible-playbooks-3.5.55-1.git.0.29802ee.el7.noarch
openshift-ansible-3.5.55-1.git.0.29802ee.el7.noarch
openshift-ansible-roles-3.5.55-1.git.0.29802ee.el7.noarch

Set it to VERIFIED and close it.
Comment 9 errata-xmlrpc 2017-04-25 17:43:07 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1140