Bug 1441934

Summary: command query-migrate-parameters has not been found
Product: Red Hat Enterprise Linux 7 Reporter: Dan Zheng <dzheng>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED ERRATA QA Contact: Fangge Jin <fjin>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.4CC: chayang, chhu, dgilbert, dyuan, dzheng, juzhang, knoel, lcheng, michen, quintela, rbalakri, virt-maint, xfu, xuzhang, yisun, zpeng
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-3.2.0-4.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-02 00:05:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dan Zheng 2017-04-13 06:42:57 UTC
Description of problem:
Command 'query-migrate-parameters' can not be found in qemu-kvm. This happens from qemu-kvm-1.5.3-135.el7.x86_64. It works on qemu-kvm-1.5.3-134.el7.x86_64

Version-Release number of selected component (if applicable):
qemu-kvm-1.5.3-135.el7.x86_64
kernel-3.10.0-632.el7.x86_64
libvirt-3.2.0-2.virtcov.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Start a guest
2. Command 'query-migrate-parameters' can not be found.

# virsh qemu-monitor-command avocado-vt-vm1 '{"execute":"query-commands"}' |grep query-migrate-parameters



Actual results:
See above

Expected results:
Command 'query-migrate-parameters' should exist.

Additional info:

Comment 3 Chao Yang 2017-04-14 09:27:29 UTC
(In reply to Dan Zheng from comment #0)
> Description of problem:
> Command 'query-migrate-parameters' can not be found in qemu-kvm. This
> happens from qemu-kvm-1.5.3-135.el7.x86_64. It works on
> qemu-kvm-1.5.3-134.el7.x86_64
> 

Are you sure? Cause I didn't see this command either with qemu-kvm-1.5.3-134.el7.x86_64

And with qemu-kvm-rhev-2.6.0-26.el7, I did observe such command, please retry with -rhev one. I think this command is only supported by -rhev

Comment 4 Dan Zheng 2017-04-14 10:37:01 UTC
After discussion with Chao Yang and reviewing libvirt CI job history, I think it may be libvirt problem. So move it to libvirt.

Comment 5 Dan Zheng 2017-04-14 11:02:47 UTC
Packages:
libvirt.x86_64 0:3.2.0-1.virtcov.el7
qemu-kvm.x86_64 10:1.5.3-134.el7 

Steps:
1. Start a guest and do migration 

# virsh  migrate avocado-vt-vm1 --live --verbose qemu+ssh://10.16.67.194:22/system

internal error: unable to execute QEMU command 'query-migrate-parameters': The command query-migrate-parameters has not been found\n\n")

2. Use libvirt.x86_64 0:3.1.0-2.virtcov.el7, it works.

Actual results:
See above

Expected results:
Command 'query-migrate-parameters' should not be invoked as it is rhev only.

Additional info:

Comment 6 Jiri Denemark 2017-04-26 21:26:39 UTC
Patch sent upstream for review: https://www.redhat.com/archives/libvir-list/2017-April/msg01328.html

Comment 7 Jiri Denemark 2017-04-27 08:36:59 UTC
Fixed upstream by

commit ac58c036065ff1d53bc05b796093287c27c71762
Refs: v3.2.0-270-gac58c0360
Author:     Jiri Denemark <jdenemar>
AuthorDate: Wed Apr 26 23:18:35 2017 +0200
Commit:     Jiri Denemark <jdenemar>
CommitDate: Thu Apr 27 10:33:18 2017 +0200

    qemu: Ignore missing query-migrate-parameters

    Migration with old QEMU which does not support query-migrate-parameters
    would fail because the QMP command is called unconditionally since the
    introduction of TLS migration. Previously it was only called if the user
    explicitly requested a feature which uses QEMU migration parameters. And
    even then the situation was not ideal, instead of reporting an
    unsupported feature we'd just complain about missing QMP command.

    Trivially no migration parameters are supported when
    query-migrate-parameters QMP command is missing. There's no need to
    report an error if it is missing, the callers will report better error
    if needed.

    https://bugzilla.redhat.com/show_bug.cgi?id=1441934

    Signed-off-by: Jiri Denemark <jdenemar>

Comment 10 Fangge Jin 2017-05-08 09:10:08 UTC
Reproduce with builds:
    libvirt-3.2.0-3.el7.x86_64
    qemu-kvm-1.5.3-137.el7.x86_64

Verify with builds:
    libvirt-3.2.0-4.el7.x86_64
    qemu-kvm-1.5.3-137.el7.x86_64

Migration can succeed now.

Comment 11 errata-xmlrpc 2017-08-02 00:05:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846

Comment 12 errata-xmlrpc 2017-08-02 01:30:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846