Bug 1442274

Summary: Review Request: nodejs-js-tokens - A regex that tokenizes JavaScript
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-20 17:24:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806, 1269538, 1387531, 1444561    

Description Jared Smith 2017-04-13 21:31:45 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-tokens/nodejs-js-tokens.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-tokens/nodejs-js-tokens-3.0.1-1.fc27.src.rpm
Description: A regex that tokenizes JavaScript
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2017-09-24 16:58:09 UTC 
Tests are failing:

  693 passing (106ms)
  2 failing
  1) tokens whitespace ᠎:
      AssertionError [ERR_ASSERTION]: 'name' == 'whitespace'
      + expected - actual
      +whitespace
      -name
      
      at Context.<anonymous> (test/index.js:49:16)
  2) tokens name a᠎:
      AssertionError [ERR_ASSERTION]: 'a᠎' == 'a'
      + expected - actual
      +a
      -a
Comment 2 Jared Smith 2018-04-20 13:30:32 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-tokens/nodejs-js-tokens.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-js-tokens/nodejs-js-tokens-4.0.0-1.fc29.src.rpm
Comment 3 Robert-André Mauchin 🐧 2018-04-20 14:12:51 UTC 
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.
Comment 4 Jared Smith 2018-04-20 16:28:48 UTC 
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6163.
Comment 5 Gwyn Ciesla 2018-04-20 16:33:19 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-js-tokens
Comment 6 Jared Smith 2018-04-20 17:24:31 UTC 
Packaged in Rawhide, closing this issue