Bug 1442310 (php-phpdocumentor-reflection1)

Summary: Review Request: php-phpdocumentor-reflection1 - Reflection library to do Static Analysis for PHP Projects (Version 1)
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-05-08 14:19:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2017-04-14 02:27:30 UTC 
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/b27ba48822a1499c1fe23f67c52c7f71c244b6f5/php-phpdocumentor-reflection1/php-phpdocumentor-reflection1.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-phpdocumentor-reflection1-1.0.7-4.fc25.src.rpm

Description:
Using this library it is possible to statically reflect one or more files
and create an object graph representing your application's structure,
including accompanying in-source documentation using DocBlocks.

The information that this library provides is similar to what the (built-in)
Reflection extension of PHP provides; there are however several advantages
to using this library:

* Due to its Static nature it does not execute procedural code in your
  reflected files where Dynamic Reflection does.
* Because the none of the code is interpreted by PHP (and executed)
  Static Reflection uses less memory.
* Can reflect complete files
* Can reflect a whole project by reflecting multiple files.
* Reflects the contents of a DocBlock instead of just mentioning there is one.
* Is capable of analyzing code written for any PHP version (starting at 5.2)
  up to and including your installed PHP version.

Features
* [Creates an object graph] containing the structure of your application much
  like a site map shows the structure of a website.
* Can read and interpret code of any PHP version starting with 5.2 up to and
  including your currently installed version of PHP.
* Due it's clean interface it can be in any application without a complex setup.


Fedora Account System Username: siwinski
Comment 1 Remi Collet 2017-04-29 05:27:21 UTC 
Created attachment 1275134 [details]
phpci.log

phpCompatInfo version 5.0.6 DB version 1.20.0 built Apr 14 2017
     16:12:51 CEST static analyze results
Comment 2 Remi Collet 2017-04-29 05:27:48 UTC 
Created attachment 1275135 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1442310
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Comment 3 Remi Collet 2017-04-29 05:28:51 UTC 
[!]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
		Obsoletes:      php-phpdocumentor-reflection < 1.0.7-3
	Should be 
		Obsoletes:      php-phpdocumentor-reflection < 1.0.7-4

[x]: Package complies to the Packaging Guidelines


Please the minor typo in Obsoletes before building.


=== APPROVED ===
Comment 4 Shawn Iwinski 2017-04-29 12:42:49 UTC 
> Please the minor typo in Obsoletes before building.

Will do.



THANKS for the review.  Pkg request submitted for F26+.
Comment 5 Gwyn Ciesla 2017-04-30 22:17:55 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-phpdocumentor-reflection1
Comment 6 Fedora Update System 2017-05-01 16:45:21 UTC 
php-phpdocumentor-reflection-common-1.0-1.fc26 php-phpdocumentor-reflection-docblock2-2.0.4-5.fc26 php-phpdocumentor-reflection1-1.0.7-5.fc26 php-phpdocumentor-type-resolver-0.2.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-14cb178d90
Comment 7 Fedora Update System 2017-05-02 06:37:52 UTC 
php-phpdocumentor-reflection-common-1.0-1.fc26, php-phpdocumentor-reflection-docblock2-2.0.4-5.fc26, php-phpdocumentor-reflection1-1.0.7-5.fc26, php-phpdocumentor-type-resolver-0.2.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-14cb178d90
Comment 8 Fedora Update System 2017-05-08 14:19:56 UTC 
php-phpdocumentor-reflection-common-1.0-1.fc26, php-phpdocumentor-reflection-docblock2-2.0.4-5.fc26, php-phpdocumentor-reflection1-1.0.7-5.fc26, php-phpdocumentor-type-resolver-0.2.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.