Bug 1442411
Summary: | meta xlator leaks memory when unloaded | ||||||
---|---|---|---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Niels de Vos <ndevos> | ||||
Component: | core | Assignee: | Niels de Vos <ndevos> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | mainline | CC: | bugs | ||||
Target Milestone: | --- | Keywords: | Triaged | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | glusterfs-3.11.0 | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2017-05-30 18:49:52 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1425623 | ||||||
Attachments: |
|
REVIEW: https://review.gluster.org/17061 (meta: free this->private in fini()) posted (#1) for review on master by Niels de Vos (ndevos) COMMIT: https://review.gluster.org/17061 committed in master by Jeff Darcy (jeff.us) ------ commit d7f0ead43969e755d07ae92c669d63527a58c572 Author: Niels de Vos <ndevos> Date: Fri Apr 14 17:19:47 2017 +0200 meta: free this->private in fini() For every graph switch or de-init (includes calling `glfs_fini`) the meta_priv_t structure (80 bytes on x86_64) leaks. Because it is allocated in the `init()` funtion, it should be free'd in `fini()`. Change-Id: Ie45a9c9a520d55bebd0eb04c2ac667bc8c1c5acb BUG: 1442411 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: https://review.gluster.org/17061 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report. glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html [2] https://www.gluster.org/pipermail/gluster-users/ |
Created attachment 1271695 [details] snippet of Valgrind output Description of problem: the meta xlator allocates a (xlator_t *this)->private structure in init(), but does not free it in fini(). This means that upon every unload of the xlator 80 bytes get lost.