Bug 1442504

Summary: Review Request: nodejs-has-values - Returns true if any values exist, false if empty
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-18 16:46:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806, 1387531, 1442506    

Description Jared Smith 2017-04-15 00:21:21 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-has-values/nodejs-has-values.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-has-values/nodejs-has-values-0.1.4-1.fc27.src.rpm
Description: Returns true if any values exist, false if empty
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2017-09-14 12:33:32 UTC 
Latest version is 1.0.0, please bump your package.
It build-requires:

BuildRequires:	npm(is-number)

for tests.

And it requires npm(is-number) >= 3.0.0 (bug #1376258).

npm(is-number) requires npm(kind-of) < 4.0.0 and npm(has-values) requires npm(kind-of) > 4.0.0, have fun with managing the dependencies! I've elected to bump everyone to npm(kind-of) == 5.0.0 by patching package.json.
Comment 2 Jared Smith 2017-09-18 15:13:47 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-has-values/nodejs-has-values.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-has-values/nodejs-has-values-1.0.0-1.fc28.src.rpm
Comment 3 Robert-André Mauchin 🐧 2017-09-18 15:27:27 UTC 
Perfect, package accepted.
Comment 4 Jared Smith 2017-09-18 15:33:18 UTC 
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1276'
Comment 5 Gwyn Ciesla 2017-09-18 15:34:45 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-has-values
Comment 6 Jared Smith 2017-09-18 16:46:32 UTC 
In rawhide, closing bug