Bug 1442510
| Summary: | Review Request: nodejs-shallow-clone - Make a shallow clone of an object, array or primitive | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-18 14:29:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1442508 | ||
| Bug Blocks: | 956806, 1387531, 1442511 | ||
|
Description
Jared Smith
2017-04-15 01:12:51 UTC
Please bump the package to version 1.0.0.
You'll probably need to bump the versions in package.json to handle the dependencies correctly:
diff -up package/package.json.fix_metadata package/package.json
--- package/package.json.fix_metadata 2017-09-14 17:32:47.905729241 +0200
+++ package/package.json 2017-09-14 17:33:25.442646994 +0200
@@ -24,9 +24,9 @@
"test": "mocha"
},
"dependencies": {
- "is-extendable": "^0.1.1",
+ "is-extendable": "^1.0.0",
"kind-of": "^5.0.0",
- "mixin-object": "^2.0.1"
+ "mixin-object": "^3.0.0"
},
"devDependencies": {
"gulp-format-md": "^1.0.0",
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-shallow-clone/nodejs-shallow-clone.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-shallow-clone/nodejs-shallow-clone-1.0.0-1.fc28.src.rpm You should %nodejs_fixdep is-extendable %nodejs_fixdep mixin-object otherwise you'll get issues with dependencies. 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1217' (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-shallow-clone In rawhide, closing bug |