Bug 1442736

Summary: UI: "Save" button is still enabled when no server is selected in "Edit Management Engine Relationship" for VM/Instance
Product: Red Hat CloudForms Management Engine Reporter: Satyajit Bulage <sbulage>
Component: UI - OPSAssignee: Brian McLaughlin <bmclaugh>
Status: CLOSED CURRENTRELEASE QA Contact: Satyajit Bulage <sbulage>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1443243 (view as bug list) Environment:
Last Closed: 2018-03-06 15:32:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1443243    

Description Satyajit Bulage 2017-04-17 10:14:00 UTC 
Description of problem:


Version-Release number of selected component (if applicable):5.8.0.10-beta1.20170411212748_e47d319 


How reproducible:100%


Steps to Reproduce:
1. Add any provider
2. Navigate to VM/Instance Summary Page
3. Click on Configuration --> Edit Management Engine Relationship
4. Select EVM server and again choose '<Not a Server>'

Actual results: "Save" button is still enabled when selection of EVM server has been reverted

Expected results: It should be disabled when EVM server selection has been reverted.


Additional info:
Comment 2 Harpreet Kataria 2017-04-17 19:50:53 UTC 
Brian,

Need to reset server id back to nil when user selects '<Not a Server>' option in drop down. Let me know if you have questions.

Thanks,
~Harpreet
Comment 3 CFME Bot 2017-04-18 14:58:30 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/1055
Comment 4 CFME Bot 2017-04-18 18:03:57 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/f7cdbdaedd7369d3249e38ed538ee9ad527d7dd1

commit f7cdbdaedd7369d3249e38ed538ee9ad527d7dd1
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Tue Apr 18 10:45:31 2017 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Tue Apr 18 10:45:31 2017 -0400

    Spec tests
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1442736

 spec/controllers/vm_common_spec.rb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
Comment 5 CFME Bot 2017-04-18 18:04:02 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/479982418b0fb7db31a0ea61fb2c9646f11f643d

commit 479982418b0fb7db31a0ea61fb2c9646f11f643d
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Tue Apr 18 10:45:58 2017 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Tue Apr 18 10:45:58 2017 -0400

    Fix 'Save' button state in Edit Management Engine Relationship for VM/Instance
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1442736

 app/controllers/vm_common.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Satyajit Bulage 2017-10-13 09:54:13 UTC 
"Save" button is Disabled when selection of EVM server has been reverted.

Verified Version: 5.9.0.2.20171010190026_0413a06