Bug 1442920
| Summary: | Error in re-configuring service: "Error during 'Provisioning': undefined method `match' for 0:Fixnum Did you mean? catch" | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Shveta <sshveta> | ||||||||
| Component: | Automate | Assignee: | eclarizi | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shveta <sshveta> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 5.7.0 | CC: | dajohnso, hkataria, jhardy, mkanoor, mpovolny, obarenbo, simaishi, sshveta, tfitzger | ||||||||
| Target Milestone: | GA | Keywords: | TestOnly | ||||||||
| Target Release: | 5.9.0 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | service | ||||||||||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | |||||||||||
| : | 1445899 1445901 (view as bug list) | Environment: | |||||||||
| Last Closed: | 2018-03-06 14:37:55 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1445899, 1445901 | ||||||||||
| Attachments: |
|
||||||||||
ALso in 5.7.2.1.20170406142927_0a1ad0e Please provider supporting logs for this issue. Created attachment 1272358 [details]
Logs
Steps to recreate : 1) Add a heat template (Service - Orchestration template- heat template - Add) 2) Create a service dialog from that template (Service - Orchestration - select template - create dialog) 3) Create a catalog item for type "Orchestration" . Provider "RHOS7-GA" selected . 4) Select template and dialog created above . 5) Order service catalog. 6) Under MyService - select service once it is provisioned. Configuration - Reconfigure service . Option fields are uneditable . Click on submit . See Error . Appliance : https://10.8.198.95 . Service name - reconfigure . Created attachment 1273030 [details] Stack dialog Appliance - https://10.8.198.237 . Service - reconfigure . Issue occurs only when timeout value is provided in the dialog . Not an issue when timeout is left blank. Eric, Please take a look. I think there is a problem with integer type textbox, particularly at reconfiguration time. The error is likely thrown at https://github.com/ManageIQ/manageiq/blob/master/app/models/dialog_field_text_box.rb#L42 What is the data type for @value? You want it be a string, but it is a number already. Hmm, I think during regular validation, the @value is actually still a string, and we convert it using to_i later. I'm sure you're correct in that the issue lies in the reconfiguration after @value has already been converted to an integer. A simple fix would be to always do to_s before attempting to match, since it gets converted to the correct data type after validation anyway. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/6491cfd00f3de68115869a4a45548e8c784d0c54 commit 6491cfd00f3de68115869a4a45548e8c784d0c54 Author: Erik Clarizio <eclarizi> AuthorDate: Mon Apr 24 08:56:29 2017 -0700 Commit: Erik Clarizio <eclarizi> CommitDate: Mon Apr 24 08:56:29 2017 -0700 Force use of string before attempting to match for text field validation https://bugzilla.redhat.com/show_bug.cgi?id=1442920 app/models/dialog_field_text_box.rb | 2 +- spec/models/dialog_field_text_box_spec.rb | 23 +++++++++++++++++------ 2 files changed, 18 insertions(+), 7 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/96a579a2dafb6e133d27952a4cf57d88029a0e7d commit 96a579a2dafb6e133d27952a4cf57d88029a0e7d Author: Erik Clarizio <eclarizi> AuthorDate: Thu May 11 13:09:17 2017 -0700 Commit: Erik Clarizio <eclarizi> CommitDate: Thu May 11 13:09:17 2017 -0700 Refactor '.match' according to rubocop rules https://bugzilla.redhat.com/show_bug.cgi?id=1442920 app/models/dialog_field_text_box.rb | 10 ++++++---- spec/models/dialog_field_text_box_spec.rb | 20 ++++++++++++++++++++ 2 files changed, 26 insertions(+), 4 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/58c47619dfc3d4e56917a7ae4536ed19aaf25fa5 commit 58c47619dfc3d4e56917a7ae4536ed19aaf25fa5 Author: Erik Clarizio <eclarizi> AuthorDate: Thu May 11 11:27:59 2017 -0700 Commit: Erik Clarizio <eclarizi> CommitDate: Thu May 11 11:27:59 2017 -0700 Force use of string when comparing for validation rule https://bugzilla.redhat.com/show_bug.cgi?id=1442920 app/models/dialog_field_text_box.rb | 2 +- spec/models/dialog_field_text_box_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Working in 5.9.0.2.20171010190026_0413a06 |
Created attachment 1272214 [details] err Description of problem: Version-Release number of selected component (if applicable): 5.8.0.10-beta1-nightly.20170414034628_b979a0b How reproducible: Steps to Reproduce: 1. Create a service for openstack and Reconfigure. 2. Shows error. 3. Actual results: Expected results: Additional info: