Bug 1444085
| Summary: | No pop-up with support case when collecting logs thru dropbox from second server in distributed mode | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Oleksii Tsuman <otsuman> | |
| Component: | UI - OPS | Assignee: | Dávid Halász <dhalasz> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Oleksii Tsuman <otsuman> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.7.0 | CC: | dajohnso, hkataria, jhardy, mpovolny, obarenbo, otsuman, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.9.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | log_collect:distributed | |||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1444504 (view as bug list) | Environment: | ||
| Last Closed: | 2018-03-06 15:01:27 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1444504 | |||
|
Description
Oleksii Tsuman
2017-04-20 14:20:01 UTC
Oleksii, can you, please, give me the IP of an appliance where you are testing this? I'd like to quickly check this and hopefully fix it while avoiding the complex setup on my dev environment. Thx! Martin, I sent to you email with IP address the necessary 'data-prompt' is not being set on the button therefor the UI does not display the prompt
when I change app/helpers/application_helper/button/collect_logs.rb
to include:
def calculate_properties
super
Rails.logger.error(['calculate_properties', :log_file_depot, @record, @record.try(:log_file_depot), @record.try(:log_file_depot).try(:requires_support_case?)].inspect)
if @record.try(:log_file_depot).try(:requires_support_case?)
self[:prompt] = true
end
end
I can see:
[----] E, [2017-04-21T06:38:07.811254 #33446:1370770] ERROR -- : ["calculate_properties", :log_file_depot, nil, nil, nil]
meaning that @record is nil
so the root cause is that @record is not being set in the controller
going to be the same bug as:
https://bugzilla.redhat.com/show_bug.cgi?id=1443927
but after the refactorings the @record is tested earlier so the button is not displayed at all
Reassigning do David, will help him fix both bzs. Oleksii: I applied a fix on your appliance. Please, take a look. New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/cfc4931dfbba7f5136ce46c66f4f685ee1cdc2d3 commit cfc4931dfbba7f5136ce46c66f4f685ee1cdc2d3 Author: Dávid Halász <dhalasz> AuthorDate: Fri Apr 21 13:09:12 2017 +0200 Commit: Dávid Halász <dhalasz> CommitDate: Fri Apr 21 13:09:12 2017 +0200 Explicitly set the @record in ops controller on diagnostics screens https://bugzilla.redhat.com/show_bug.cgi?id=1443927 https://bugzilla.redhat.com/show_bug.cgi?id=1444085 app/controllers/ops_controller.rb | 1 + app/controllers/ops_controller/diagnostics.rb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) Martin, thanks, now on my appliance pop-up present when trying to collect logs (current and all) from master, slave and zone. verified in 5.9.0.2.20171010190026_0413a06 |