Bug 1444518
| Summary: | Review Request: libcoap - C library implementation of CoAP | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Jared Smith <jsmith.fedora> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora, jorton, jsmith.fedora, package-review, pwhalen |
| Target Milestone: | --- | Flags: | pbrobinson:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-10 10:08:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1269538 | ||
|
Description
Peter Robinson
2017-04-21 13:53:22 UTC
I am not a packager, so this is not an official review. I noticed the %files section uses > %{_datadir}/man/man5/coap*.gz The wiki page says you should not assume that gzip is used, and use a pattern which reflects that. Also, you may use %{_mandir} instead of %{_datadir}/man. https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages As a minor note, the %descriptions for -devel and -docs use the %{name} macro, whereas the -utils subpackage uses a bare string. > %package docs > Summary: Documentation package for %{name} > Requires: %{name}%{?_isa} = %{version}-%{release} > BuildArch: noarch Please don't do that. Really keep documentation packages free of superfluous dependencies, so they can be installed without pulling in an unknown chain of stuff that is _not_ needed to view the documentation. Also, if you make it "noarch", adding an arch-specific Requires won't work reliably, since the noarch build may be created on any build host. Finally, the packaging guidelines still recommend -doc not -docs: https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation All of the above fixed locally, won't push new version up until a proper review SPEC: as above SRPM: https://pbrobinson.fedorapeople.org/libcoap-4.1.2-2.fc26.src.rpm Latest RC version of 4.2 SPEC: https://pbrobinson.fedorapeople.org/libcoap.spec SRPM: https://pbrobinson.fedorapeople.org/libcoap-4.2.0-0.1.rc2.fc29.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=30478080 Minor nit, passing --disable-static to configure rather than throwing away the .a files afterwards looks cleaner. rpmlint picks up License: and a few other trivialities I think the License: tag should just be "BSD" since the LICENSE text is a 2-clause BSD and there is no code included here under the OpenSSL license. The fact that it links to OpenSSL does need to be mentioned in License. libcoap-doc.noarch: W: invalid-license BSD + OpenSSL libcoap-doc.noarch: W: invalid-url URL: https://libcoap.net/ Remote end closed connection without response libcoap-doc.noarch: W: file-not-utf8 /usr/share/doc/libcoap/AUTHORS libcoap.x86_64: W: incoherent-version-in-changelog 4.2.0-0.1-rc2 ['4.2.0-0.1.rc2.fc29', '4.2.0-0.1.rc2'] libcoap.x86_64: W: invalid-license BSD + OpenSSL libcoap.x86_64: W: invalid-url URL: https://libcoap.net/ Remote end closed connection without response libcoap.x86_64: W: shared-lib-calls-exit /usr/lib64/libcoap-2-openssl.so.0.1.0 exit.5 libcoap.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libcoap-2-openssl.so.0.1.0 SSL_CTX_set_cipher_list libcoap.x86_64: W: file-not-utf8 /usr/share/doc/libcoap/AUTHORS libcoap-devel.x86_64: W: invalid-license BSD + OpenSSL libcoap-devel.x86_64: W: invalid-url URL: https://libcoap.net/ Remote end closed connection without response libcoap-utils.x86_64: W: invalid-license BSD + OpenSSL libcoap-utils.x86_64: W: invalid-url URL: https://libcoap.net/ Remote end closed connection without response libcoap-utils-debuginfo.x86_64: W: invalid-license BSD + OpenSSL libcoap-utils-debuginfo.x86_64: W: invalid-url URL: https://libcoap.net/ Remote end closed connection without response 7 packages and 0 specfiles checked; 0 errors, 19 warnings. SPEC: as above SRPM: https://pbrobinson.fedorapeople.org/libcoap-4.2.0-0.1.rc4.fc29.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=32692722 I have reviewed this package, and it needs a couple of minor fixups, but is otherwise APPROVED. The package follows the Fedora Packaging Guidelines, and is under a proper license. Please consider applying the following changes before pushing the package to Fedora: --- libcoap.spec.orig 2019-02-09 15:14:46.030448525 -0500 +++ libcoap.spec 2019-02-09 15:20:15.054881402 -0500 @@ -6,9 +6,9 @@ Summary: C library implementation of CoAP URL: https://libcoap.net/ # If build against gnutls the license is BSD + LGPL 2.1 -License: BSD + OpenSSL +License: BSD -Source0: https://github.com/obgm/libcoap/archive/v%{version}.tar.gz#/%{name}-%{version}%{?candidate:-%{candidate}}.tar.gz +Source0: https://github.com/obgm/libcoap/archive/v%{version}%{?candidate:-%{candidate}}.tar.gz#/%{name}-%{version}%{?candidate:-%{candidate}}.tar.gz BuildRequires: autoconf BuildRequires: automake @@ -94,7 +94,7 @@ %{_libdir}/libcoap-2*.so %changelog -* Sat Feb 9 2019 Peter Robinson <pbrobinson> 4.2.0-0.1-rc4 +* Sat Feb 9 2019 Peter Robinson <pbrobinson> 4.2.0-0.1.rc4 - Update to 4.2.0 rc4 * Sat Jul 1 2017 Peter Robinson <pbrobinson> 4.1.2-2 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libcoap Thanks for the review |