Bug 1444736

Summary:	Review Request: perl-re-engine-PCRE2 - PCRE2 regular expression engine for Perl
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-re-engine-PCRE2-0.11-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-25 08:19:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2017-04-24 07:29:01 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-re-engine-PCRE2/perl-re-engine-PCRE2.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-re-engine-PCRE2/perl-re-engine-PCRE2-0.11-1.fc27.src.rpm
Description:
This Perl module replaces perl's regex engine in a given lexical scope with
PCRE2 regular expressions provided by libpcre2-8.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-04-24 11:43:56 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-re-engine-PCRE2-0.11-1.fc27.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libpcre2-8.so.0()(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.10.0
      1 perl(XSLoader)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-re-engine-PCRE2-0.11-1.fc27.x86_64.rpm | sort | uniq -c
      1 perl(re::engine::PCRE2) = 0.11
      1 perl-re-engine-PCRE2 = 0.11-1.fc27
      1 perl-re-engine-PCRE2(x86-64) = 0.11-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-re-engine-PCRE2*
perl-re-engine-PCRE2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-re-engine-PCRE2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-re-engine-PCRE2.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-re-engine-PCRE2/LICENSE
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
NOTE: incorrect-fsf-address was reported to upstream

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-04-24 12:45:04 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-re-engine-PCRE2

Comment 3 Petr Pisar 2017-04-25 08:19:58 UTC

Thank you for the review and the repository.