Bug 1444773

Summary:	explicitly specify executor to be bash for tests
Product:	[Community] GlusterFS	Reporter:	Nithya Balachandran <nbalacha>
Component:	tests	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs, rtalur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1438858	Environment:
Last Closed:	2017-05-31 20:46:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1438858
Bug Blocks:	1442603

Description Nithya Balachandran 2017-04-24 09:17:47 UTC

+++ This bug was initially created as a clone of Bug #1438858 +++

Description of problem:
We use prove command to run tests. Sometimes tests fail rather strangely with error as shown below:



Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
./tests/bugs/core/bug-1111557.t .. 
Dubious, test returned 25 (wstat 6400, 0x1900)
No subtests run

https://build.gluster.org/job/centos6-regression/3818/consoleFull
https://build.gluster.org/job/centos6-regression/3819/consoleFull
https://build.gluster.org/job/centos6-regression/3801/consoleFull



Quote from man page

```
 "--exec"
       Normally you can just pass a list of Perl tests and the harness will know how to execute them.  However, if your tests are
       not written in Perl or if you want all tests invoked exactly the same way, use the "-e", or "--exec" switch:

        prove --exec '/usr/bin/ruby -w' t/
```

Hence, better to comply with recommended practice although it might not be the reason for this failure.

--- Additional comment from Worker Ant on 2017-04-04 10:59:33 EDT ---

REVIEW: https://review.gluster.org/16996 (explicitly specify executor to be bash for tests) posted (#1) for review on master by Raghavendra Talur (rtalur)

--- Additional comment from Worker Ant on 2017-04-04 11:18:50 EDT ---

REVIEW: https://review.gluster.org/16996 (explicitly specify executor to be bash for tests) posted (#2) for review on master by Raghavendra Talur (rtalur)

--- Additional comment from Worker Ant on 2017-04-05 09:09:44 EDT ---

COMMIT: https://review.gluster.org/16996 committed in master by Jeff Darcy (jeff.us) 
------
commit d6b88e9b8b02813620c3c1a2ea49d58d29062b3e
Author: Raghavendra Talur <rtalur>
Date:   Tue Apr 4 20:28:07 2017 +0530

    explicitly specify executor to be bash for tests
    
    We use prove command to run tests. Sometimes tests fail rather strangely
    with error as shown below:
    
    Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
    ./tests/bugs/core/bug-1111557.t ..
    Dubious, test returned 25 (wstat 6400, 0x1900)
    No subtests run
    
    https://build.gluster.org/job/centos6-regression/3818/consoleFull
    https://build.gluster.org/job/centos6-regression/3819/consoleFull
    https://build.gluster.org/job/centos6-regression/3801/consoleFull
    
    Quote from man page
    
    ``
     "--exec"
           Normally you can just pass a list of Perl tests and the harness
    will know how to execute them.  However, if your tests are not written in Perl
    or if you want all tests invoked exactly the same way, use the "-e",
    or "--exec" switch:
    
            prove --exec '/usr/bin/ruby -w' t/
    ```
    
    Hence, better to comply with recommended practice although it might not
    be the reason for this failure.
    
    Change-Id: If7a0baf20698f8497ef3e8fc422fa67063a4651f
    BUG: 1438858
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: https://review.gluster.org/16996
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: N Balachandran <nbalacha>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Nigel Babu <nigelb>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 1 Worker Ant 2017-04-24 09:22:35 UTC

REVIEW: https://review.gluster.org/17103 (explicitly specify executor to be bash for tests) posted (#1) for review on release-3.10 by N Balachandran (nbalacha)

Comment 2 Worker Ant 2017-04-24 15:32:17 UTC

COMMIT: https://review.gluster.org/17103 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit e37d546042a73bec85fe2ebd0146b88b7079bc66
Author: Raghavendra Talur <rtalur>
Date:   Tue Apr 4 20:28:07 2017 +0530

    explicitly specify executor to be bash for tests
    
    We use prove command to run tests. Sometimes tests fail rather strangely
    with error as shown below:
    
    Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
    ./tests/bugs/core/bug-1111557.t ..
    Dubious, test returned 25 (wstat 6400, 0x1900)
    No subtests run
    
    https://build.gluster.org/job/centos6-regression/3818/consoleFull
    https://build.gluster.org/job/centos6-regression/3819/consoleFull
    https://build.gluster.org/job/centos6-regression/3801/consoleFull
    
    Quote from man page
    
    ``
     "--exec"
           Normally you can just pass a list of Perl tests and the harness
    will know how to execute them.  However, if your tests are not written in Perl
    or if you want all tests invoked exactly the same way, use the "-e",
    or "--exec" switch:
    
            prove --exec '/usr/bin/ruby -w' t/
    ```
    
    Hence, better to comply with recommended practice although it might not
    be the reason for this failure.
    
    > BUG: 1438858
    > Signed-off-by: Raghavendra Talur <rtalur>
    > Reviewed-on: https://review.gluster.org/16996
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: N Balachandran <nbalacha>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Nigel Babu <nigelb>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Jeff Darcy <jeff.us>
    (cherry picked from commit d6b88e9b8b02813620c3c1a2ea49d58d29062b3e)
    
    Change-Id: If7a0baf20698f8497ef3e8fc422fa67063a4651f
    BUG: 1444773
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: https://review.gluster.org/17103
    Tested-by: N Balachandran <nbalacha>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Raghavendra Talur 2017-05-31 20:46:29 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report.