Bug 1445005

Summary:	Error page when going to Reconfigure for Instance
Product:	Red Hat CloudForms Management Engine	Reporter:	Petr Blaho <pblaho>
Component:	UI - OPS	Assignee:	Petr Blaho <pblaho>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ido Ovadia <iovadia>
Severity:	high	Docs Contact:
Priority:	high
Version:	unspecified	CC:	cpelland, hkataria, iovadia, jhardy, lcouzens, mpovolny, obarenbo, simaishi, tzumainn
Target Milestone:	GA	Keywords:	TestOnly
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	vm:reconfigure
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1445802 (view as bug list)		Environment:
Last Closed:	2018-03-06 15:55:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	Openstack	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1445802

Description Petr Blaho 2017-04-24 17:39:56 UTC

Description of problem:
Error message when going to Reconfigure of Instance dialog page.

Version-Release number of selected component (if applicable):
master branch of upstream repos of manageiq, manageiq-ui-classic, manageiq-providers-openstack


How reproducible:
Always

Steps to Reproduce:
1. Have a VM in OpenStack
2. Go to detail page of that VM
3. Click on "Configuration" in toolbar, then "Reconfigure this instance"

Actual results:
Page with error message "undefined method `find_by' for
"admin":String [vm/resize]"

Expected results:
Page with dialog for reconfiguring of VM.

Additional info:
The same page (and error) can be accessed via list of VMs, selecting VM and clicking on "Configuration" in toolbar, then "Reconfigure selected instance"

Solved by https://github.com/ManageIQ/manageiq-ui-classic/pull/1139
Comments of upstream PR contains screenshots.

Comment 2 Dave Johnson 2017-04-25 15:14:02 UTC

Same here as see alsos, osp only or something we are missing?

Comment 3 luke couzens 2017-04-25 18:45:54 UTC

This is OSP only.

Comment 4 CFME Bot 2017-04-26 06:58:15 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/52c029d8999a5859c92b57efedff57bdfe171a18

commit 52c029d8999a5859c92b57efedff57bdfe171a18
Author:     Petr Blaho <pblaho>
AuthorDate: Mon Apr 24 15:19:06 2017 +0200
Commit:     Petr Blaho <pblaho>
CommitDate: Mon Apr 24 20:09:23 2017 +0200

    Use correct params for find_record_with_rbac in resize method
    
    find_record_with_rbac expects ActiveRecord like class as first parameter.
    During previous refactoring a mistake was introduced and session[:userid] was
    passed as first parameter and that caused "undefined method `find_by' for
    "admin":String [vm/resize]" when trying to go to reconfigure a VM dialog page.
    
    This corrects that.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445005

 app/controllers/application_controller/ci_processing.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 6 Ido Ovadia 2018-01-30 12:46:08 UTC

Verified
========
5.9.0.16