Bug 1445034

Summary: Munin plugin 'mysql_' fails with "Use of uninitialized value in printf at ... line 885."
Product: [Fedora] Fedora EPEL Reporter: sumatej
Component: muninAssignee: Kim B. Heino <b>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: epel7CC: b, drjohnson1, ingvar
Target Milestone: ---   
Target Release: ---   
Hardware: noarch   
OS: Linux   
Whiteboard:
Fixed In Version: munin-2.0.40-2.fc28 munin-2.0.40-2.el6 munin-2.0.40-2.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-06 03:08:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1445048    
Bug Blocks:    

Description sumatej 2017-04-24 18:46:18 UTC
Description of problem:
When there are missing some InnoDB statistics data (or parsing was not completely successful) Munin plugins `/etc/munin/plugins/mysql_innodb_io_pend` and `/etc/munin/plugins/mysql_innodb_insert_buf` report error "Use of uninitialized value in printf at ... line 885." which causes that all InnoDB related graphs are with zero values.

When lines 885-886 of file "/usr/share/munin/plugins/mysql_" (from munin-node package) are updated to:
        printf "%s.value %s\n",
            clean_fieldname($ds->{name}),
            defined $data->{$ds->{name}} ? $data->{$ds->{name}} : 'U';
it works without error and graphs are there.

Original lines 885-886 are:
        printf "%s.value %s\n",
            clean_fieldname($ds->{name}), $data->{$ds->{name}};

Proposed change is taken from the latest plugin sources:
https://github.com/munin-monitoring/munin/blob/3fff4fd45972dbfbfee3c7b0d5af653cb4aa3cfb/plugins/node.d/mysql_#L1811,L1813

Version-Release number of selected component (if applicable):
munin-node-2.0.33-1.el7.noarch.rpm

How reproducible:


Steps to Reproduce:
1. Install and configure munin

2. Enable some munin mysql innodb plugin e.g.:
ln -sf /usr/share/munin/plugins/mysql_ /etc/munin/plugins/mysql_innodb_io_pend
systemctl restart munin-node

2. Create some InnoDB table

3. Run:
munin-run mysql_innodb_io_pend

Comment 1 Fedora Update System 2018-08-25 08:36:01 UTC
munin-2.0.40-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-60e7ab00eb

Comment 2 Fedora Update System 2018-08-25 08:36:56 UTC
munin-2.0.40-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-e42294dd9f

Comment 3 Fedora Update System 2018-08-25 08:37:30 UTC
munin-2.0.40-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-d7fccd52d3

Comment 4 Fedora Update System 2018-08-25 22:37:12 UTC
munin-2.0.40-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-60e7ab00eb

Comment 5 Fedora Update System 2018-08-25 23:05:03 UTC
munin-2.0.40-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-d7fccd52d3

Comment 6 Fedora Update System 2018-08-25 23:06:02 UTC
munin-2.0.40-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-e42294dd9f

Comment 7 Fedora Update System 2018-09-06 03:08:58 UTC
munin-2.0.40-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2018-09-11 13:47:38 UTC
munin-2.0.40-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2018-09-11 14:44:29 UTC
munin-2.0.40-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.