Bug 144514
| Summary: | fence_sanbox2: failure path locks user out of admin mode | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Cluster Suite | Reporter: | Derek Anderson <danderso> |
| Component: | fence | Assignee: | Marek Grac <mgrac> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Cluster QE <mspqa-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4 | CC: | cluster-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-31 18:01:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Patch applied: Checking in fence_sanbox2.pl; /cvs/cluster/cluster/fence/agents/sanbox2/fence_sanbox2.pl,v <-- fence_sanbox2.pl new revision: 1.2; previous revision: 1.1 done Checking in fence_sanbox2.pl; /cvs/cluster/cluster/fence/agents/sanbox2/fence_sanbox2.pl,v <-- fence_sanbox2.pl new revision: 1.1.2.1; previous revision: 1.1 done Can we close this one? Looks like we probably shipped it. |
Description of problem: If the command fails then the session is currently just closed. The sanbox is touchy about this because you were in admin mode. Even though the session is dropped the switch still thinks it is in admin mode and won't allow any one else in there until you manually log in and execute 'admin cancel'. When locked out you get this error message. failed: parallel telnet session Proposed solution is simply to drop out of admin mode if the command fails. @@ -161,6 +161,9 @@ if (!((($opt_o =~ /disable/i) && ($text =~ /AdminState\ *Offline/i)) || (($opt_o =~ /enable/i) && ($text =~ /AdminState\ *Online/i)))) { + # Get out of admin mode before failing + $t->print("admin end"); + $t->waitfor('/\>/'); fail "failed: could not change state to $opt_o\n"; } Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: