Bug 1445259

Summary: telnet won't build with latest gcc
Product: [Fedora] Fedora Reporter: Michal Ruprich <mruprich>
Component: telnetAssignee: Michal Ruprich <mruprich>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: luhliari, mruprich, msekleta
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: telnet-0.17-69.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-30 00:19:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch none

Description Michal Ruprich 2017-04-25 11:31:34 UTC
Created attachment 1273880 [details]
Patch

Description of problem:

When trying to build telnet with rpmbuild on rawhide fedora, the build finishes with a few "format not a string literal and no format arguments [-Werror=format-security]" errors. This is caused by new version of gcc-7.0. The -Werror=format-security flag was used before in the same way but gcc-6.3 probably didn't force the error, because telnet build was fine. 

Fortunately this can be fixed by editing couple of fprintf functions in telnet. I am providing a patch that fixes the issue.

Version-Release number of selected component (if applicable):
gcc-7.0.1
telnet-0.17-67

How reproducible:
Always

Steps to Reproduce:
Rebuild telnet with rpmbuild on rawhide

Actual results:
Build finishes with format not a string literal and no format arguments [-Werror=format-security] error

Expected results:
Build is successful

Additional info:

Comment 1 Fedora Update System 2017-04-25 12:48:30 UTC
telnet-0.17-69.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-66124f3904

Comment 2 Fedora Update System 2017-04-26 03:52:49 UTC
telnet-0.17-69.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-66124f3904

Comment 3 Fedora Update System 2017-04-30 00:19:47 UTC
telnet-0.17-69.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.