Bug 1445522

Summary: The credentials for Automate Git Repository wasn't updating the correct authentications type
Product: Red Hat CloudForms Management Engine Reporter: mkanoor
Component: UI - OPSAssignee: mkanoor
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: cpelland, dclarizi, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1450217 1458892 (view as bug list) Environment:
Last Closed: 2018-03-06 15:21:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1450217, 1458892    

Description mkanoor 2017-04-25 21:15:35 UTC 
Description of problem:
We support multiple authentication types, the GitRepository was supposed to be using the default type, it was using a type called values.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a GitRepository with a valid URL from the rake command
2. From the UI Automate Import/Export target the same Repository, change the userid/password
3. It would update the incorrect credentials.

Actual results:
We should have a single credential instead of multiple, the UI creates one called values the rake task creates one called default.

Expected results:
A single credential type called default should be used for a single Git Repository

Additional info:
Comment 2 CFME Bot 2017-04-25 21:28:47 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/1157
Comment 4 CFME Bot 2017-04-26 06:53:16 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/84b1ce70a15aaf34cb63a15fdb569239574b9f58

commit 84b1ce70a15aaf34cb63a15fdb569239574b9f58
Author:     mkanoor <mkanoor>
AuthorDate: Tue Apr 25 17:18:27 2017 -0400
Commit:     mkanoor <mkanoor>
CommitDate: Tue Apr 25 17:18:27 2017 -0400

    Incorrect authentication_type being used
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445522
    
    We should be using the :default authentication type

 app/services/git_repository_service.rb       | 2 +-
 spec/services/git_repository_service_spec.rb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 7 Milan Falešník 2017-11-03 10:10:22 UTC 
Verified in 5.9.0.5 using https://bugzilla.redhat.com/show_bug.cgi?id=1458892#c3